Plugins extending ContextAwarePluginBase are not able to define context values via configuration as intended

Let me check the , will the patch get failed or not ?

I can confirm that there clearly is a mismatch but apparently nothing in core uses this. We definitely need some tests to show how this is supposed to work.

A related problem here is that plugin configuration is internal. Constructors shouldn't document its structure, as the allowed configuration is equal to whatever ConfigurablePluginInterface::getConfiguration() returns: an array with arbitrary content, as decided by the plugin itself. This is what caused this problem to be hidden in the first place.

This patch builds upon @rakesh.gectcr's original solution, but also deprecates the aforementioned behavior, and documents the better alternative approach.

+++ b/core/modules/node/src/Tests/Condition/NodeConditionTest.php
@@ -79,7 +79,9 @@ function testConditions() {
     // Test Constructor injection.
-    $condition = $manager->createInstance('node_type', array('bundles' => array('article' => 'article'), 'context' => array('node' => $article)));
+    /** @var \Drupal\node\Plugin\Condition\NodeType $condition */
+    $condition = $manager->createInstance('node_type', array('bundles' => array('article' => 'article')));
+    $condition->setContextValue('node', $article);
     $this->assertTrue($condition->execute(), 'Constructor injection of context and configuration working as anticipated.');

+++ b/core/modules/user/src/Tests/Condition/UserRoleConditionTest.php
@@ -141,7 +141,9 @@ public function testConditions() {
     // Test Constructor injection.
-    $condition = $this->manager->createInstance('user_role', array('roles' => array(RoleInterface::AUTHENTICATED_ID => RoleInterface::AUTHENTICATED_ID), 'context' => array('user' => $this->authenticated)));
+    /** @var \Drupal\user\Plugin\Condition\UserRole $condition */
+    $condition = $this->manager->createInstance('user_role', array('roles' => array(RoleInterface::AUTHENTICATED_ID => RoleInterface::AUTHENTICATED_ID)));
+    $condition->setContextValue('user', $this->authenticated);
     $this->assertTrue($condition->execute(), 'Constructor injection of context and configuration working as anticipated.');

This is explicitly testing the constructor injection of context. Please revert.

I don't think a Novice can review this.

Re-roll.

I noticed this typo, then found that this issue had already been posted. Fixing the typo would be a one-line change as in the original patch (although the test coverage is a lot more than that). So I am curious why you replace

    $context_configuration = isset($configuration['context']) ? $configuration['context'] : [];
    unset($configuration['context']);

    parent::__construct($configuration, $plugin_id, $plugin_definition);

    $this->contexts = $this->createContextFromConfiguration($context_configuration);

with

    parent::__construct($configuration, $plugin_id, $plugin_definition);
    if (isset($configuration['context'])) {
      trigger_error(sprintf('Passing contexts in plugin configuration has been deprecated, because contexts are no real plugin configuration. Use %s::setContext() instead.', static::class), E_USER_DEPRECATED);
      $context_configuration = $configuration['context'];
      unset($configuration['context']);
      $this->context = $this->createContextFromConfiguration($context_configuration);
    }

This does the following:

1. Fix the typo.
2. Move the unset() from before the parent constructor to after (at which point it is irrelevant).
3. Add a deprecation notice.
4. Move the definition of $this->context inside an if block.

Of these, (1) is the original point of this issue. Does (2) make a difference? You explained your reasons for (3) in #4. I do not know enough to agree or disagree with that decision, but it seems like scope creep for this issue. I also do not know whether (4) is a good idea, but it is a change, and might break some code.

The deprecation notice is not translatable. Also, there is a typo (or grammatical mistake). If we decide to keep it, I suggest something like

      $message = t('Passing contexts in plugin configuration has been deprecated, because contexts are not real plugin configuration. Use %method instead.', array('%method' => static::class . '::setContext()'));
      trigger_error($message, E_USER_DEPRECATED);

The whole BC dance and fix was done here #3080631: Context values passed in configuration to ContextAwarePluginBase are disregarded.