Port uc_shipping to D8

Do you have the Shipping module enabled? This has not been fully ported yet and looks to be the cause of this issue.

uc_shipping has not been ported to D8 yet.
Most stores don't need or use this module, it only does back-end fulfillment. Shipping quotes are done with uc_quote and don't need uc_shipping.

The order View does work without uc_shipping enabled.

If uc_shipping is important to you, please consider working on the port yourself and contributing a patch or sponsoring the development. We need to redesign the workflow of uc_shipping because it has always been very clumsy and overly complicated to use for the typical situation where you only have 1 box per order.

Better title.

I'm currently making a first pass at the port of uc_shipping to D8. It's now called uc_fulfillment. I will be using this issue as a patch testing issue until I get it to the point where it can be enabled and run without crashing a site.

I don't plan to do much in the way of redesigning at the moment - that' might come after it's ported.

First attempt at porting - this moves most of the code out of .module and .admin.inc (all of the code in .admin.inc has been removed) and into Forms and Controlers. hook_menu() has been removed, routes have been added.

I'm going to commit this chunk and set this issue back to needs work - this module still can't be enabled, it will take a few more iterations to find and fix all the D7 stuff still in there.

Major work, the module can now be enabled, and you can make packages and shipments from the tabs on the order view. It's going to stay "Needs work" and "not_yet_ported" until I've got everything working - I don't need bug reports at this stage.

First pass at a set of tests for uc_fulfillment. This tests the process almost all the way to the end - I'm still working on finishing off the port. These tests work locally, but let's see how they fair in the CI environment. This will also check to see whether the proper operation of uc_fulfillment depends on changes to other parts of Ubercart that I've made locally but haven't committed yet ...

Another set of tests to check all the features of packaging.

Again...

Removed all uc_fulfillment_package_xxx and uc_fulfillment_shipment_xxx crud functions from .module and moved them into two classes, Package and Shipment. For now these are just normal classes, but I made them have the same method signatures (create, load, save, delete) as Entities because the goal is to next turn these into entities.

Packages and shipments were both treated as arrays and/or stdClass objects throughout the code, so I replaced those usages with the new classes. Fortunately I had written > 250 test cases - they were very helpful when making this conversion to objects to make sure everything still worked when I was done!

Without the patch to .info.yml, which is now already committed.

Back to needs work. But you can now enable this module and play with it, and there are many working tests. Right now the problems remaining are:

• Address Ajax doesn't work on ShipmentEdit form / NewShipment form.
• ShipmentEdit form doesn't find the correct values for addresses and a few other things.
• Final submission of the shipment whitescreens, but the shipment is made and can be viewed.
• Invoice and print tabs of the shipment whitescreen because the theme functions haven't been ported / still reference theme() etc.

Once these are made to work I still have to add some new tests to make sure they stay working.

Test reverting a patch.

Again.

Again.

Reroll of some botched patches.

Retry ed8383

Retry 568ce

Rework 0b859

Rework 5dca1c

Rework ea6b8f

Rework 40a19

Make shipment properties protected.

uc_fulfillment is now ported and working.

There are still a few minor issue, and some changes I'd like to make under the hood which don't affect the UI, so I'll keep this issue open for testing patches for a little while longer.

Add package currency code and weight/weight units.

Use Package setters/getters, protect properties.

Remove db_ calls and use Package/Shipment API instead.

Same, but with a new test.

Some new tests for shipments.

Use OrderProduct entity instead of {uc_order_products} table.

Init Package variables, simplify save().

The module has been ported and working since #57. While there are still things I'd like to do to improve the code internally, these things won't affect anyone wanting to use this code. Marking this as fixed.