Hello,

We are applying shipping fees to the order in many more places than the checkout form. As a result of this, every time we do this the line item is deleted and then recreated, as designed inside commerce_shipping_rate_apply().

This patch is to make sure line items are always reused, to allow for more ajax-based interaction with the user in future versions of this module, and to at the same time save line item ids.

CommentFileSizeAuthor
#4 reuse_shipping_line_items-2621478-4.patch3.25 KBperiksson
#2 reuse_shipping_line_items-2621478-2.patch2.6 KBperiksson
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nwpullman2 created an issue. See original summary.

periksson’s picture

periksson CreditAttribution: periksson commented
FileSize
reuse_shipping_line_items-2621478-2.patch2.6 KB

Patch flying in

periksson’s picture

periksson CreditAttribution: periksson commented
Status: Active » Needs review
periksson’s picture

periksson CreditAttribution: periksson commented
FileSize
reuse_shipping_line_items-2621478-4.patch3.25 KB

Missed a method in my first patch, commerce_shipping_update_line_item(). Attaching a complete patch this time.

donquixote’s picture

donquixote CreditAttribution: donquixote commented

We are applying shipping fees to the order in many more places than the checkout form.

Can you name some such situations other than checkout?
It depends on rules config, right? And every such case would be a call to commerce_shipping_rate_apply()?