Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
It would be nice if a display option Colorbox is available to show the video in a colorbox.
I installed colorbox 8.x-1.x-dev but the display option is not available in the video field.
Comments
Comment #2
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedI have started working on this feature for 8.x. Patch should be incoming soon.
Comment #3
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedSee patch.
Comment #4
jibranLGTM
This can be injected. Don't you want to check install instead of exist.
Comment #5
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented> ModuleHandler::moduleExists
> Determines whether a given module is enabled.
Also, the method is static, so can't inject a dependency.
Comment #6
jibranYes, you are right it is still confusing sometimes D8 doesn't have a disable state :). Correct on static method too. So looks good RTBC.
Comment #7
jibranMaybe move this to preRender.
Comment #8
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedNot sure what that would look like. Is there any example of this anywhere?
Comment #9
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedGoing to commit this and have it battle tested in an RC2. I will follow-up with the early rendering with some more manual testing and look into the preRender use case.
Comment #11
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented