Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.This would let us have multiple instances of a single payment method. We should also move the method configuration forms inside the plugins themselves so they are more self contained.
| Comment | File | Size | Author |
|---|---|---|---|
| #26 | escape-payment-options.patch | 2.78 KB | longwave |
| #22 | payment-config.patch | 51.52 KB | longwave |
Comments
Comment #2
longwaveWorking on this.
Comment #3
longwaveFirst pass, still needs the actual payment methods to be converted and the interfaces etc to be finished off.
Comment #4
longwaveThis will fail tests but I want to see which ones and how badly.
Comment #6
longwaveComment #7
longwaveOops, needed to rebase first.
Comment #10
longwaveComment #12
longwaveComment #14
longwaveHopefully this will pass all tests; still needs a bit more cleanup but maybe that can be done in followups. Reviews and comments welcome, though!
Comment #15
TR CreditAttribution: TR commentedI say just commit it. I didn't check it extensively, but what I looked at looked fine and worked. Planning on doing the same thing for gateways?
Oh, there is one place where you use the entity.manager service instead of entity_type.manager ... don't want that creeping back in ...
Comment #16
longwaveYes. Credit card is no longer its own payment method, gateways will just subclass the credit card base class. I still need to create an interface and move the charge method to the class, and there are a few other cleanups we can do such as remove the credit card field selection from the UI and make it the responsibility of the implementing class to declare the fields it actually needs.
I will commit this later, and then keep the issue open for the followups.
Comment #18
longwaveComment #19
longwaveHm, the tests are inconsistent, seems we get fails if the generated payment method label contains an &
Comment #20
longwaveComment #22
longwaveThis finishes the conversion for gateways.
Comment #26
longwaveComment #28
longwave#26 works for me, I can't get any of those tests to fail. It's as if DrupalCI is not actually applying the patch...
Comment #30
longwaveStill not entirely sure what those test fails are about, can't reproduce any of them locally. This seems stable enough to commit and mark as fixed, and let's deal with any fallout later.