Follow-up to #2612590: Allow configuring in the UI the image formats supported by the toolkit

Problem/Motivation

Remove the Todo2311679 class when Drupal core issue #2311679: Separate MIME type mapping from ExtensionMimeTypeGuesser, or similar, is solved.

Proposed resolution

Replace the Todo2311679 class with a mapper class that uses Reflection to access the $mapping property of ExtensionMimeTypeGuesser.

Remaining tasks

User interface changes

none

API changes

Replace the Todo2311679 class with a ImagemagickMimeTypeMapper class.

Data model changes

none

CommentFileSizeAuthor
#3 2620930-3.patch7.8 KBmondrake
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mondrake created an issue. See original summary.

mondrake’s picture

Version: 8.x-1.x-dev » 8.x-2.x-dev
Assigned: Unassigned » mondrake
Issue summary: View changes
Status: Postponed » Active

#2311679: Separate MIME type mapping from ExtensionMimeTypeGuesser is completely stalled. For D8, I will use Reflection to access the $mapping property of ExtensionMimeTypeGuesser after it has loaded additional MIME types via hook_file_mimetype_mapping_alter.

mondrake’s picture

Status: Active » Needs review
FileSize
7.8 KB

Patch.

  • mondrake committed 930aed1 on 8.x-2.x
    Issue #2620930 by mondrake: Remove the Todo2311679 class
    
mondrake’s picture

Version: 8.x-2.x-dev » 8.x-1.x-dev
Status: Needs review » Patch (to be ported)

Committed to 8.x-2.x; leaving open for porting to 8.x-1.x

mondrake’s picture

Assigned: mondrake » Unassigned
mondrake’s picture

Status: Patch (to be ported) » Fixed

Backport is unlikely at this stage.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.