For Drupal 8 Panels uses the layout_plugin to generate their layouts. This very nice because we can re-use layouts in Display Suite as well. For this reason I create a new project with the intention merging Display Suite Bootstrap Layouts and Panels Bootstrap Layouts into one central place using the layout_plugin project.

Here is the project: Bootstrap Layouts - https://www.drupal.org/project/bootstrap_layouts

What you guys think on deprecating this project ?

Comments

darol100 created an issue. See original summary.

mrded’s picture

mrded CreditAttribution: mrded as a volunteer and at WikiJob for WikiJob commented
Category: Bug report » Support request
mrded’s picture

mrded CreditAttribution: mrded as a volunteer and at WikiJob for WikiJob commented

Have you reuse the codebase of Display Suite Bootstrap Layouts and Panels Bootstrap Layouts modules?

darol100’s picture

darol100 CreditAttribution: darol100 as a volunteer and commented

I did not use the code of any other project, because in D8 the implementation is totally different. The only thing that it shares is the Bootstrap classes.

darol100’s picture

darol100 CreditAttribution: darol100 as a volunteer and commented

BTW, I do not know if @markcarver is an authority in this project but it seem like he already mention that this project is been deprecated it. See more at - https://www.drupal.org/node/2267595#comment-10593164

mrded’s picture

mrded CreditAttribution: mrded as a volunteer and at WikiJob for WikiJob commented

No, he is not.

Anyway I'm going to support this project for D7. And I'm going to update it to D8.
As I see, in bootstrap_layouts module you cannot build layouts as flexible as with panels_bootstrap_layouts.

Updating panels_bootstrap_layouts to D8 will also means using the layout_plugin and supporting Display Suite. So it's not going to be deprecated.

I personally always happy to see new modules, you may implement it better than we did. Feel free to ask an advice, if you need.

More modules - better!

darol100’s picture

darol100 CreditAttribution: darol100 as a volunteer and commented

you cannot build layouts as flexible as with panels_bootstrap_layouts

Can you explain to me what is what it make it easier to generate layouts ? I think we should join forces instead of competition. And I'm open for suggestion for new features instead of having two separate modules solving the same problem.

As long we can keep it modular enough does not add extra wrappers for Panels that does not need in DS. And Vice-versa I do not want to add extra things in DS that will affect or add complexity on Panels if is not need it.

This project history it was to solve the to add layouts in Panels, since we do not do that anymore to me this just going to make it more confusing (IMO).

mrded’s picture

mrded CreditAttribution: mrded as a volunteer and at WikiJob for WikiJob commented

In bootstrap_layouts, you provide 19 static layouts with one, two and three columns. What if you want to show different size of columns for different devices?
Let's say you pick 8 - 4 for desktop and you want to make it 6 - 6 on tablet. You cannot do that with bootstrap_layouts module.

More over, there are not all possible combinations of layouts. How to do 8 - 2 - 2?

panels_bootstrap_layouts provides just two layouts 'Three Columns Stacked' & 'Two Columns Stacked'. And you can set it up as you like.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Related issues: +#2267595: [meta][ds_bootstrap_layouts] Port to 8.x

Sorry, I wasn't trying to step on any toes.

I just haven't seen much activity on this project and certainly haven't seen any plans to port to D8. We were asked in the ds_bootstrap_layouts issue queue (where I am a maintainer) and given that I'm busy with other things (like porting the main bootstrap base theme) to D8, I certainly would welcome any consolidation that eliminates me from the equation.

The related bootstrap_layouts module has combined both DS and Panel's needs using the layout plugins... was just thinking I was doing the community a favor by eliminating the need for separate modules finally. I for one would certainly prefer to use just one contrib project that can support both modules.

If anything, I would imagine asking to become a maintainer of the bootstrap_layouts module and instead simply leave this one for D7, but that's just me I guess...

darol100’s picture

darol100 CreditAttribution: darol100 as a volunteer and commented

#8

Let's say you pick 8 - 4 for desktop and you want to make it 6 - 6 on tablet. You cannot do that with bootstrap_layouts module.

This is because initially, I use it ds_boostrap_layouts as example to build this project and as far I know does not support that. This project is not 100% done that is why I have not make a official release. Things kinda feature it will be nice to have as long we can support it on Panels as well in DS.

More over, there are not all possible combinations of layouts. How to do 8 - 2 - 2?

We can support that as well, I have actually open a new issue for this #2622710: Support for 8-2-2 and 2-2-8 templates.

was just thinking I was doing the community a favor by eliminating the need for separate modules finally.

There are too many projects out there solving the same issue with few additional features and sometimes is hard to pick which one.

If anything, I would imagine asking to become a maintainer of the bootstrap_layouts module and instead simply leave this one for D7, but that's just me I guess...

I like this idea of having a co-maintainer, to help me out bringing new ideas into bootstrap_layouts. @mrded, I can make you a maintainer of bootstrap_layouts so we can both work together in one project instead of duplicating the same code across different projects. What you think about be co-maintainer of bootstrap_layouts ?

mrded’s picture

mrded CreditAttribution: mrded as a volunteer and at WikiJob for WikiJob commented

I like an idea of having one module instead of many. However I believe that panels may require some specific settings which cannot be implemented just in a layout.

I would suggest to keep it as it is and see how things will go. If you manage to make your module a fully functional, we will talk about merging.
As I said above I just don't think that you will cover panel's users needs.

mrded’s picture

mrded CreditAttribution: mrded as a volunteer and at WikiJob for WikiJob commented

@darol100, now I think, I agree with you that one general module can replace both of them.

It looks like with layout_plugin you can make settings available in Display Suite Bootstrap Layouts and Panels Bootstrap Layouts modules.

I made a few suggestions to make Bootstrap Layouts module a replacement of Panels Bootstrap Layouts:

Can you please take a look, and tell me what do you think? I may add some more suggestions on a way, if I find any.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer commented
Issue tags: +london_2016_january

Just discussed this in global sprint weekend and it feels like both modules trying to solve different problems. One with list of layouts and one allows to generate layouts dynamically. May be we should keep them separate. Let's not deprecate any.

If @mrded and @darol100 agree, let's close this issue.

mrded’s picture

mrded CreditAttribution: mrded as a volunteer commented
Status: Active » Closed (fixed)

I agree. I think it would make sense to keep Bootstrap Layouts module static, as it works already.
And convert current one to D8, so it will provide dynamic layouts.

darol100’s picture

darol100 CreditAttribution: darol100 as a volunteer and commented

@mrded, I think you should have a separate project that generate layouts and it should not be under the name space Panels Bootstrap Layouts.

ChandeepKhosa’s picture

ChandeepKhosa CreditAttribution: ChandeepKhosa at 2Toucans commented
Issue tags: +SprintWeekend2016
mrded’s picture

mrded CreditAttribution: mrded as a volunteer commented

#2659578: My thoughts about D8 porting