Biblio module: importing ris files, titles not importing even though mapped correctly [#2619626]

I have ris files of citations to upload, and despite having titles mapped correctly at admin/config/content/biblio/iomap/edit/ris -- T1 goes to Title, I get nothing but "untitled" nodes. I am using version 7.x-1.0-rc7. Some other data seems to populate appropriately, but looking at logs, many things aren't, so it's more than just titles. I have a large number of errors for a number of fields along the lines of:

Notice: Undefined property: stdClass::$title in _biblio_ris_parse_line() (line 357 of C:\wamp\www\mysite\sites\all\modules\biblio\modules\RIS\biblio_ris.module).

Thinking there might be something wrong with the data, I created my own simple ris file and tried an example file that I found online. I had the same problems with all of them.

I tried the dev version and have the same problem.

Any help would be appreciated.

Comment	File	Size	Author
#12	biblio-importing-ris-files-2619626-12.patch	823 bytes	byronveale
#12	7.x-1.x: PHP 7.2 & MySQL 5.5, D7.63 Patch Failed to Apply

Issue fork biblio-2619626

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

2619626-biblio-module-importing changes, plain diff MR !6
Check out this branch

About issue forks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

20 November 2015 at 00:58

mattrweaver created an issue. See original summary.

Comment #2

mattrweaver CreditAttribution: mattrweaver commented 20 November 2015 at 20:04

Actually, I made have fixed it, thanks to an idea from this comment.

I changed two lines in biblio_ris.module:

339 from
$node->biblio_pages .= ($tag == "SP") ? $data : " - " . $data;
to
$node->biblio_pages = ($tag == "SP") ? $data : " - " . $data;

and 357, from:
$node->$field .= $data;
to
$node->$field = $data;

I've never written a patch before, but I'll give it a shot.

Comment #3

rjerome CreditAttribution: rjerome commented 21 November 2015 at 15:43

Could you attach a RIS file that generates this error (no title), I would like to take a look at it.

Comment #4

mattrweaver CreditAttribution: mattrweaver commented 23 November 2015 at 02:05

I used this one:

http://www.refbase.net/index.php/Import_Example:_RIS

Comment #5

mattrweaver CreditAttribution: mattrweaver commented 23 November 2015 at 02:22

and while I got title to work, some other fields aren't like Pubmed id.

Comment #6

rjerome CreditAttribution: rjerome commented 25 November 2015 at 01:58

I imported that Refbase example RIS file without issue, so I'm guessing your issue may be related to the PHP version or settings that you are using.

Can you elaborate on your PHP version and the platform its running on?

Comment #7

mattrweaver CreditAttribution: mattrweaver commented 25 November 2015 at 13:14

I had started to think this was likely the issue. I am running 5.5.12 (wampserver). I also had trouble with 5.6 (xampp). And I won't bother with the patch, then

Comment #8

mattrweaver CreditAttribution: mattrweaver commented 30 November 2015 at 13:02

okay, tried php5.4 and it works. Thanks

Comment #9

HunterElliott CreditAttribution: HunterElliott commented 4 January 2016 at 22:56

Just an FYI, I'm also getting this error on PHP Version 5.5.9-1ubuntu4.14

Comment #11

pdau2571 CreditAttribution: pdau2571 commented 21 November 2016 at 10:28

Hello,
I've got same problem: all fields of RIS file except Pub Date and authors are not imported. Log file of DRUPAL displays this message:
Notice: Undefined property: stdClass::$title in _biblio_ris_parse_line() (line 357 of /path/to/site/sites/all/modules/biblio/modules/RIS/biblio_ris.module).
Same message for other biblio_fields.
A previous message states that this error is due to PHP version. Any idea about how to solve this issue without modifying PHP version?
Thanks,
Pierre