Google map doesn't appear for fields inside of closed Paragraphs [#2619140]

When the field is used inside of a closed Paragraph (https://www.drupal.org/project/paragraphs), the map isn't being rendered when creating a new or editing an existing Paragraph.

Steps to reproduce:
1. Download and install both Paragraphs (https://www.drupal.org/project/paragraphs) and Geolocation.
2. Create a new paragraph bundle and add a geolocation field to it (use any of the google maps widgets).
3. Add a paragraphs field to any content type and activate the bundle we created in step 2.
4. Create new page and add a new paragraph.

Expected result:
New Paragraph appears with Google Map being shown.

Actual result:
In case of Google Map widget it dies with js error "Uncaught ReferenceError: google is not defined". In case of Google Map D8 widget the Paragraph appears without the Map.

Comment	File	Size	Author
#19	interdiff_18-19.txt	472 bytes	CRZDEV
#19	geolocation-google-map-closed-paragraphs-2619140-19-7.x.patch	4.14 KB	CRZDEV
#19
#18	geolocation-google-map-closed-paragraphs-2619140-18-7.x.patch	4.07 KB	CRZDEV
#18
#15	geolocation_d7_paragraphcompatibility-2619140-15.patch	14.92 KB	shawngo
#15
#2	geolocation_googlemaps-paragraphcompatibility-2619140-1-7.x.patch	12.72 KB	quiron
#2	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 Patch failed to apply

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

19 November 2015 at 16:07

andrejsmuzikovs created an issue. See original summary.

Comment #2

quiron

Catalan

Barcelona

CreditAttribution: quiron commented 7 March 2016 at 17:46

File	Size
geolocation_googlemaps-paragraphcompatibility-2619140-1-7.x.patch	12.72 KB
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 Patch failed to apply

I have the same problem, and I soved it with using $.ajax complete control. The patch is working for me.

Anyone can test please?

Comment #3

derjochenmeyer CreditAttribution: derjochenmeyer at forward-media.de commented 8 March 2016 at 22:52

Status:

Active

» Needs review

Comment #4

8 March 2016 at 22:54

Status:

Needs review

» Needs work

The last submitted patch, 2: geolocation_googlemaps-paragraphcompatibility-2619140-1-7.x.patch, failed testing.

Comment #5

RgnYLDZ CreditAttribution: RgnYLDZ commented 29 March 2016 at 22:03

I don't know if this is related but I'm using views megarow that displays the node content. The node content has a dynamic map field as display.

Because the megarow is loaded on a click event manually, the google libraries are not loaded I think. So the first megarow content gives the "Uncaught ReferenceError: google is not defined" error.

The second megarow I click displays the content and the map without any problem.

Maby an approach like "Load libraries on every page" would solve this quickly, like the colorbox module.

Comment #6

derjochenmeyer CreditAttribution: derjochenmeyer at forward-media.de commented 28 April 2016 at 17:38

Status:

Needs work

» Postponed (maintainer needs more info)

Did anyone test this patch?

Comment #7

29 April 2016 at 14:07

Status:

Postponed (maintainer needs more info)

» Needs work

The last submitted patch, 2: geolocation_googlemaps-paragraphcompatibility-2619140-1-7.x.patch, failed testing.

Comment #8

rcodina CreditAttribution: rcodina commented 27 May 2016 at 14:16

Similar problems with Inline Entity From. Same error:

Uncaught ReferenceError: google is not defined

The patch doens't work for me (for Inline Entity Form).

Comment #9

ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commented 8 June 2016 at 13:01

Status:	Needs work	» Closed (duplicate)
Related issues:		+#2689921: Empty Google maps widget when using field in Paragraphs

Unless proven otherwise, this is assumed fixed by #2689921

Please test if issue still relevant.

Comment #10

RgnYLDZ CreditAttribution: RgnYLDZ commented 11 June 2016 at 00:19

Status:

Closed (duplicate)

» Active

This issue is about D7.

Also the patch did not work for me. Still the first opening megarow table is not loading the map, the second one is.

Comment #11

ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commented 12 June 2016 at 15:09

@RgnYLDZ,

sorry, I assumed D8.

Comment #12

GiorgosK

Chios, Greece 🇬🇷

CreditAttribution: GiorgosK commented 15 June 2016 at 14:57

Same problem with dynamically loaded entity (which includes geolocation field map widget)
when using https://www.drupal.org/project/views_infinite_scroll

is there a way to call the map initilization on ajax.complete ?

Comment #13

GiorgosK

Chios, Greece 🇬🇷

CreditAttribution: GiorgosK commented 15 June 2016 at 16:30

Tried

    $(document).ajaxComplete(function(){
      Drupal.attachBehaviors();
    });

but it does not work
anything else I could try ?

Comment #14

Bensbury CreditAttribution: Bensbury as a volunteer commented 31 October 2016 at 03:18

I couldn't apply the patch either.

error: patch failed: modules/geolocation_googlemaps/geolocation_googlemaps_widget.js:186
error: modules/geolocation_googlemaps/geolocation_googlemaps_widget.js: patch does not apply

Shame if it actually fixes the problem.

Comment #15

shawngo CreditAttribution: shawngo commented 31 January 2017 at 05:02

File	Size
geolocation_d7_paragraphcompatibility-2619140-15.patch	14.92 KB

I applied the patch manually and exported a new patch which applied cleanly to the latest dev. The patch also removes extra spacing and a couple coding standards issues.

The patch fixed the issue when loading the Google Map widget on a paragraph field.

Comment #16

ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commented 31 January 2017 at 14:23

Hey,

how is this distinct from https://www.drupal.org/node/1277888?

Comment #17

tko CreditAttribution: tko commented 13 February 2017 at 07:21

Patch from #15 fixed the problem.
But you're unable to add more than 1 paragraph which includes a map. The admin UI is blank for the second map. I suppose this is a separate issue?

Comment #18

CRZDEV CreditAttribution: CRZDEV as a volunteer and at Metadrop commented 9 April 2018 at 15:38

Component:	Google Maps geolocation	» Geolocation Field / Backend
Status:	Active	» Needs review

File	Size
geolocation-google-map-closed-paragraphs-2619140-18-7.x.patch	4.07 KB

New patch to solve this problem, i realised that id was equal in all cases so here goes a new patch to solve that.
And also load google maps and execute callback function if required to prevent js exception: https://developers.google.com/maps/documentation/javascript/tutorial
This patch should work even with multiple and nested paragraphs. Please review.