Concise compatibility labels

+1 I like the short and sweet. Easier to comprehend.

+1 less is more

I understand I got a bit busy 3 months ago as we started to negotiate the CG acquisition, but I think we should revisit this as it was clear in IRC last week that these settings were misunderstood when the labels were proposed. I actually find the new labels lend themselves more to confusion than the old, which is probably why Joel had a hard time understanding them... or at least we should've made sure everyone understood the field and its impact before shortening them.

In doing so, we can also add some help text that makes it clear the compatibility checks are performed in sequence, first checking the compatibility requirements of discounts already added to an order and then checkout the requirements of the current discount itself. Note that this setting is in a vertical tab now, so concision isn't as essential as it was before.

@ rszrama - So are we wanting to revert back to the old messages and add some help text to better clarify the rules for discount compatibility ?

Undecided on the course of action - just needs a little more attention. : )

Took a shot at trying to make it more clear and concise

Compatibility with already applied discounts
Discounts are applied in order of their weight, discounts compatibility only applies to discounts that have already been applied, not discounts that will be applied after this. When setting up compatibility remember to consult your discounts weighting.

Any already applied discount
Any already applied discount except for the selected discount
Only the selected already applied discounts
No already applied discounts

*possibly switch to "lower weighted discount" although I thought that was hard to follow when visualizing the checkout.

changed "already applied" to active to be even more concise. and some other words

Any active discount
Any active discount except the selected discounts
Only the active selected discounts
Not with any discounts

Any takers on the wording? Is smccabe's wording correct then? i can post a patch for that if that's the correct terminology...

Here it is. @joelpittet, the change you made in the first patch:

-        '#title' => t('Compatibility with other discounts'),
+      '#title' => t('Discount compatibility'),

Must have got committed somewhere else, cuz the change was already made to the admin file. Am I crazy? Or is my patch ok?

Hi Just saw this issue, perhaps I can help, clean up the english and make it more concise but understandable.

Compatibility with discounts already applied.
Discounts are applied in order of their weight, discount compatibility only applies to active discounts, not discounts that will be applied later. When setting up compatibility remember to consult your discount's weighting.

Any active discount.
Any active discount except the selected discount.
Only the selected active discount.
No active discounts.

I hope that helps.

Hey Tim,

I'm up for any tweakin, but it isn't just active discounts, it is literally only active discounts that are ALREADY active on the order, if another one gets added on right after, that doesn't count, the weighting is very important, which is what i was trying to convey.

No worries
Attempt #2

Discounts are applied in order of their weight, discount compatibility only applies to already active discounts, not discounts that will be applied later. When setting up compatibility remember to consult your discount's weighting.

Any already active discount.
Any already active discount except the selected discount.
Only the selected already active discount.
No already active discounts.

"Already active" is more sensible than "already applied" allowing use of applied in the description as a verb (sorry a bit english teacherish but better english) "Active" is quite common usage in drupal as in "a commerce product is active".

Works for me, I follow your reasoning, Jacer can you update the patch pretty plz

so should the label be:

Compatibility with discounts already applied.
Compatibility with discounts already active.
Compatibility with discounts already activated.

ok here's the patch. went with Compatibility with discounts already applied. for the label. This patch requires you to run and update as that appears to be the only way to reset the field's label and add the description.

In the Discount UI I purposefully avoided talking about "weight" in favor of "sort order." Weight just has mixed connotations in eCommerce, but it's also not user friendly to non-developers. Let's fix that and also change the quotation type in the description so we don't have an escape character in a translatable string.

I'm also not 100% on the idea of "active" discounts being used as shorthand for "already applied." Discounts have a status, and an active discount is one whose status is active, not more specifically one whose status is active that has already been applied to a product or order.

@rszrama, was smccabe's description better then? should "Discounts are applied in order of their weight," be "Discounts are applied in the order they are sorted," or something like that?

Revisited it as was still in my issues queue and have a bit of time on my hands to contribute/
Taking @rszrama's comments on board

The choices referred to in the options are for discounts already active and applied.

so the heading would I think be
Compatibility with discounts already active and applied.

The options can then be quite simple

• Any discount.
• Any discount except the selected discount.
• Only the selected discount.
• No discounts.

That makes sense, I think it is as unambiguous as you can get it, though I wonder if there is an option of adding a description that elaborates on the meaning of "discounts already active and applied" just to remove all doubt.

here's the patch with @TechnoTim2010 changes

edit: i'm an idiot, grab the patch from the next comment

:)

This proposal loses some precision. The second and third options support multiple selected discounts. I'll also need to compare it against the originals - can't remember 'em off the top of my head. ^_^

@rszrama the original text is in the photo at the top of the issue. or are you talking about something else?

made the discounts plural, and changed weight to sort order in the description.

Any discount except the selected discount(s).
Only the selected discount(s).

Covers it I think.

covered!

Revisiting this issue as I address #2916628: Update the labels of the compatibility radios to clarify compatibility scope. Rereading the thread, I see the proposed help text is actually inaccurate ... discount compatibility does govern whether or not discounts can apply on top of existing discounts. (e.g. if the first discount applied to an order says it is not compatible with any other discount, no other discount will be able to apply to the order.)

That said, since we've also had to reduce the scope of compatibility checks to discounts of the same type, the labels would need to be updated once again ... and I think it reflects more than just making them concise as this issue originally intended. When I reopened this, that wasn't the case, but I'm going to go ahead and close it now and approach it with a "clean slate" mindset given we need a more holistic update here if that's alright.