How about this:

Before: Drupal\inline_entity_form\InlineEntityForm\EntityInlineEntityFormHandler
After: Drupal\inline_entity_form\Form\EntityInlineForm

Before: Drupal\inline_entity_form\InlineEntityForm\NodeInlineEntityFormHandler
After: Drupal\inline_entity_form\Form\NodeInlineForm

This makes it more parallel with regular forms, which is what we want for DX reasons.
I am also not opposed to keeping the Handler suffix, in which case we might want to have them in "src" and not "src/Form".

CommentFileSizeAuthor
#10 interdiff-10.txt3.5 KBjoshi.rohit100
#10 2618154-10.patch7.09 KBjoshi.rohit100
#4 2618154-4.patch4.22 KBjoshi.rohit100
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bojanz created an issue. See original summary.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented

Should note that it seems that most handlers no longer have the Handler suffix in D8.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm at Examiner.com commented
Issue tags: +Media Initiative, +D8Media, +Novice
joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
CreditAttribution: joshi.rohit100 commented
Status: Active » Needs review
FileSize
2618154-4.patch4.22 KB

Status: Needs review » Needs work

The last submitted patch, 4: 2618154-4.patch, failed testing.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm at Examiner.com commented 
+++ b/src/Form/EntityInlineForm.php
@@ -21,7 +21,7 @@ use Symfony\Component\DependencyInjection\ContainerInterface;
-class EntityInlineEntityFormHandler implements InlineEntityFormHandlerInterface {

Let's rename interface too.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
CreditAttribution: joshi.rohit100 commented
Assigned: Unassigned » joshi.rohit100
joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
CreditAttribution: joshi.rohit100 commented

InlineEntityFormInterface ?

slashrsm’s picture

slashrsm CreditAttribution: slashrsm at Examiner.com commented

If we'd try to match name changes in #4 it would be InlineFormInterface.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
CreditAttribution: joshi.rohit100 commented
Status: Needs work » Needs review
FileSize
2618154-10.patch7.09 KB
interdiff-10.txt3.5 KB
slashrsm’s picture

slashrsm CreditAttribution: slashrsm as a volunteer commented

Committed. Thanks!

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
CreditAttribution: joshi.rohit100 commented
Assigned: joshi.rohit100 » Unassigned
Status: Needs review » Fixed

Status: Fixed » Needs work

The last submitted patch, 10: 2618154-10.patch, failed testing.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs work » Fixed

I miss Travis.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.