Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Just some comment fixes.
Comment | File | Size | Author |
---|---|---|---|
#6 | 2617822-6-code-comments.patch | 1.31 KB | czigor |
#2 | 2617822-2-code-comments.patch | 1.25 KB | czigor |
Comments
Comment #2
czigor CreditAttribution: czigor at Liip commentedComment #3
jhodgdonThanks for the issue and patch, and sorry it didn't get reviewed earlier -- I've been on vacation and hardly anyone else reviews documentation patches. :(
This needs some work though:
Let's actually fix the doc block. It should start with a one-line summary.
Then a blank line
Then it can have additional paragraphs of explanation.
Then at the end, the @var line.
Hm. It looks like the option is called "empty_column", not "hide empty column"?
Comment #4
czigor CreditAttribution: czigor at Liip commented@2: I meant the settings label in the UI which is "Hide empty column". Should I use the setting machine name or capitalize this one?
Comment #5
jhodgdonEither way. :)
Comment #6
czigor CreditAttribution: czigor at Liip commentedComment #7
jhodgdonBetter, thanks! Committed to 8.0.x and 8.1.x, with small grammar fix of which->that.