Unsplash

Howdy,

I do love me some dummyimage and I was alerted via an electronic mail message that one of my favorite image sites, unsplash, just rolled out an image generator site: https://source.unsplash.com/

Not sure if another service is what this module needs, but I'm gonna submit a patch anyway.

Comment	File	Size	Author
#3	dummyimage-unsplash-2617702-local-test.txt	40 KB	ao5357
#2	dummyimage-unsplash-2617702-2.patch	2 KB	tomgeekery

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

18 November 2015 at 01:53

tomgeekery created an issue. See original summary.

File	Size
dummyimage-unsplash-2617702-2.patch	2 KB

Comment #3

ao5357 CreditAttribution: ao5357 commented 14 January 2016 at 13:09

Status:

Needs review

» Reviewed & tested by the community

File	Size
dummyimage-unsplash-2617702-local-test.txt	40 KB

Ran tests to determine if the unsplash patch worked as intended:

Installed fresh standard Drupal 7
Installed dummyimage-7x-1-x-dev, placecage, devel, and devel_generate
Added field_image to basic page and configured it to display large images at the teaser view mode
Turned on and configured dummyimage to show Nic Cage for all images. Confirmed it worked
Applied patch against dev
Enabled unsplash, cleared cache, changed the placecage setting to unsplash
Reloaded the test content -- images changed from cage to unsplash-looking photos
Enabled core testing module and ran all tests -- results attached
Downloaded/enabled coder and ran it against dummyimage and unsplash -- no errors for unsplash

Everything worked as expected. In testing, I found that there were quite a few errors and fails relating to files; this may be related to running dummyimage, but I do not believe the unsplash service specifically.