From #2614014: Progress bar, fieldsets, messages broken in the installer due to theme ordering bug, checking the test coverage for theme ordering in getActiveThemeByName() which is purportedly mostly duplicated by _drupal_maintenance_theme() which diverged and caused the regression in that issue.

This patch should cause explicit test failures about the theme ordering.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

xjm created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, theme-ordering-FAIL.patch, failed testing.

xjm’s picture

OK, looks like \Drupal\system\Tests\Theme\RegistryTest::testMultipleSubThemes() has explicit coverage. So it was just the maintenance theme code path having duplicated the code and then diverging.

xjm’s picture

Status: Needs work » Closed (works as designed)