I counted them , all 9511 numbers. HO~~~ They are alive, I can't find the way to finish them, will somebody tell me how to clean this plz?

btw:
In the operations page (/advagg/operations), I've all readly clicked CLEAR ALL CACHES and all other buttons , kill js files wrongly , /sites/default/files/advagg_js/ ***js files only cleaned.

HelllllllllllllllllllllllP P P P

2015-11-27 14:35:34
Solution：#12

CommentFileSizeAuthor
#16 advagg-2617138-15-fix-drush.patch6.27 KBmikeytown2
#9 advagg-2617138-9-temp-file-cleanup.patch6.2 KBmikeytown2
#8 advagg-2617138-7-report-rename-failures.patch3.71 KBmikeytown2
1.jpg1010.46 KBCedar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Cedar created an issue. See original summary.

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented

What's the full path and filename to one of the js files? Don't forget to breathe.

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented

Ah I see the attached image.

Files are created by drupal_tempnam() inside the advagg_save_data() function. Long story short you have a file permissions issue. AdvAgg can create the temp files but for some reason it can not rename/move them to the final location.

Cedar’s picture

Cedar CreditAttribution: Cedar commented

Thx @mikeytown2
/sites/default/files/file_advagg_W9xnpP.js

Breathing better now.

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented

I'll add in some checks so that these temp files get removed if a failure happens and log it as well. Also advagg_update_7204 has some code that is close to what you're looking for in terms of a bulk removal of these.

Cedar’s picture

Cedar CreditAttribution: Cedar commented

Wow, great man , great module , I will keep following this .

  • mikeytown2 committed 84a6353 on 7.x-2.x 
    Issue #2617138 by mikeytown2: rename failures now go to watchdog.
mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
FileSize
advagg-2617138-7-report-rename-failures.patch3.71 KB

First step is to have watchdog report rename errors. This patch has been committed.

Next step is to clean up the files that where left behind in you case.

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
Version: 7.x-2.15 » 7.x-2.x-dev
Status: Active » Needs work
FileSize
advagg-2617138-9-temp-file-cleanup.patch6.2 KB

Following patch has been committed. Still need to work on drush support and fix plural wording. With the latest dev cron will clean it up (runs once every 24 hours) and there is a button on the operations page to do so under cron.

  • mikeytown2 committed ea7ea38 on 7.x-2.x 
    Issue #2617138 by mikeytown2: Cleanup old temp files from write failures...
Cedar’s picture

Cedar CreditAttribution: Cedar commented

Get it. Thanks very much.

Cedar’s picture

Cedar CreditAttribution: Cedar commented

It works.

Upgrade(or replace) the AdvAgg Version to 7.x-2.x-dev ,
Go to /admin/config/development/performance/advagg/operations ,
Chose " DELETE LEFTOVER TEMPORARY FILES ",
Done.

Cedar’s picture

Cedar CreditAttribution: Cedar commented
Issue summary: View changes
Cedar’s picture

Cedar CreditAttribution: Cedar commented
Status: Needs work » Fixed

  • mikeytown2 committed e25fc01 on 7.x-2.x 
    Issue #2617138 by mikeytown2: Add the new items from cron into drush...
mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
FileSize
advagg-2617138-15-fix-drush.patch6.27 KB

Fixed drush output with this commit

  • mikeytown2 committed 54fd850 on 7.x-2.x 
    Issue #2617138 by mikeytown2: Use format_plural in some of the cron task...
mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented

This commit uses format_plural
http://cgit.drupalcode.org/advagg/commit/?id=54fd850dac543c2f273d9abdb60...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.