Correct me if I'm wrong but I think links rendered in the Current Search block should use current_search_link_active() theme function, not the facetapi_link_active().

Current workaround to use a dedicated theme for a link is to use field grouping as in item_group.inc #61 correct function is used. However, if I don't want to use grouping I cannot provide a separate theme for facet's active/checked item and current search block's item.

CommentFileSizeAuthor
#5 facetapi--item-active-theme-2617028-5.patch630 bytesndf
#2 item-active-theme-2617028-1.patch618 bytesaltavis
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

altavis created an issue. See original summary.

altavis’s picture

altavis CreditAttribution: altavis commented
FileSize
item-active-theme-2617028-1.patch618 bytes

patch attached

interdruper’s picture

interdruper CreditAttribution: interdruper commented
Related issues: +#1942922: Use a separate theme function for the active items in the current search blocks

See related discussion https://www.drupal.org/node/1942922

ndf’s picture

ndf CreditAttribution: ndf at Dx Experts commented
Parent issue: » #1942922: Use a separate theme function for the active items in the current search blocks
Related issues: -#1942922: Use a separate theme function for the active items in the current search blocks

Made "Use a separate theme function for the active items in the current search blocks (1942922)" the parent issue, because it blocks this one.
Basically this patch is fine, but current_search_link_active will render different then theme_facetapi_link_active and this is can be regression for existing sites.

ndf’s picture

ndf CreditAttribution: ndf at Dx Experts commented
FileSize
facetapi--item-active-theme-2617028-5.patch630 bytes

Reroll #2, this patch applies against 7.x-1.x-dev

  • eugene.ilyin committed 226b8a2 on 7.x-1.x authored by altavis 
    Issue #2617028 by altavis, ndf: Use correct theme function to render an...
  • eugene.ilyin committed c6c4613 on 7.x-1.x
    Issue #2617028 by altavis, ndf: Use correct theme function to render an...
eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin as a volunteer and at DrupalJedi commented

I think you're right @altavis. Committed.

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin as a volunteer and at DrupalJedi commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.