Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#29 | scanner-n2616640-29.patch | 1.5 KB | DamienMcKenna |
Comments
Comment #2
minghui.yu CreditAttribution: minghui.yu commentedComment #3
arpee CreditAttribution: arpee as a volunteer commentedI am observing the same.
Replacements are listed for undo but not executed.
Comment #4
vimokkhadipa CreditAttribution: vimokkhadipa as a volunteer commentedis the same for me
Comment #5
SomebodySysop CreditAttribution: SomebodySysop commentedSame exact issue here. Can anyone report whether this is a bug or a configuration problem on our end? What is the solution?
Comment #6
gtoffoli CreditAttribution: gtoffoli as a volunteer commentedIt looks like the module assumes that the field content to replace is set to the same language as the node.
At line 1032 in the function scanner_execute, I added a check if the language is actually used, otherwise LANGUAGE_NONE is used.
Now it works.
Hope this helps.
Giulio
Comment #7
_vid CreditAttribution: _vid commentedAwesome @gtoffoli. Thanks.
That worked for me on the latest version: 7.x-1.0-beta1; starting at line 999.
I git cloned the module and made your change into a patch.
Patched against HEAD on 7.x-1.x.
Details:
622898d (HEAD, tag: 7.x-1.0-beta1, origin/HEAD, origin/7.x-1.x, 7.x-1.x)
Comment #8
Eric_A CreditAttribution: Eric_A commented@gtoffoli, @_vid, here's a version that matches the original code that went in and regressed later. (Assuming it wasn't deleted on purpose.)
Original patch: https://www.drupal.org/files/issues/scanner-use_correct_field_language-1...
#1668686-24: Replacement is not happening in drupal 7 version (with non-standard language) got in in October 2105. See http://cgit.drupalcode.org/scanner/commit/?id=bd29f83
(This was before "Support search and replace in summary part of text area fields" and "Text field deltas not respected" got in.)
Comment #13
Eric_A CreditAttribution: Eric_A commentedFails are explained in #2645590: Ensure that simpletest job doesn't "fail" testing if no tests are present .
Comment #18
Eric_A CreditAttribution: Eric_A commentedRe-uploading with "Do not test" value for "Test with" selector.
Comment #19
petschep CreditAttribution: petschep commentedThanks for the patch, worked perfect for me
Comment #20
suraj_vantagode CreditAttribution: suraj_vantagode commented#6 worked for me. Thanks a lot..
I have one concern that is, Can I execute this module through drush commands. Because I cant able extend max_execution_time in stage and production so.
I tried with the Drush search and replace module, but that will replace entire thing, I can't able to restrict replace should only for body content.
Comment #21
danheisel CreditAttribution: danheisel commented#6 worked for me as well. Any idea when this will be rolled into a release?
Comment #22
xaa CreditAttribution: xaa as a volunteer commented#18 working here. thanks
Comment #23
urix CreditAttribution: urix commented#18 works for me, version 7.x-1.x-dev.
#6 will not work, because of different position of patch
Comment #24
hass CreditAttribution: hass commentedThanks! With patch #18 all my content is preplaced properly now.
Patch looks good to go.
Comment #25
Bool Boost CreditAttribution: Bool Boost commentedIt works. Thanks.
Comment #26
Eric_A CreditAttribution: Eric_A commentedPatch #18 (RTBC'ed) is a re-upload of #8 but without the testing facilities active. The test infrastructure should be working again now with this project, so re-testing both #7 and #8.
Comment #27
Eric_A CreditAttribution: Eric_A commentedAll green.
Comment #28
DamienMcKennaComment #29
DamienMcKennaRerolled.
Comment #30
DamienMcKennaComment #32
DamienMcKennaCommitted.