Basic integration with the plugin project. All this does is:

- it follows the convention introduced by the plugin module for plugins (plugin.plugin_configuration.TYPE.ID)
- it adds a facetapi.plugin_type.yml file that defines the used plugin types and their plugin manager.

Files: 
CommentFileSizeAuthor
#6 integration_with_the-2616108-6.patch3.02 KBborisson_

Comments

borisson_ created an issue. See original summary.

borisson_’s picture

Issue tags: -Needs committer feedback

We discussed this at this weeks hangout and we decided we're going to wait a little bit to implement this to see if other contrib modules are going to be using this.

borisson_’s picture

Attached patch is the minimum needed for the plugin module to know about our plugins.

borisson_’s picture

Issue summary: View changes
Xano’s picture

  1. +++ b/facetapi.plugin_type.yml
    @@ -0,0 +1,24 @@
    +  label: Processor
    

    These labels are rather generic. This won't break anything at all, but may be slightly confusing in lists of plugins of different modules.

  2. +++ b/facetapi.plugin_type.yml
    @@ -0,0 +1,24 @@
    +  plugin_definition_decorator_class: \Drupal\plugin\PluginDefinition\ArrayPluginDefinitionDecorator
    

    Did you confirm your definition array keys can all be read by the decorator? If not, you may need to subclass the default decorator provided by Plugin. See Plugin's BlockPluginDefinitionDecorator for inspiration.

borisson_’s picture

FileSize
3.02 KB

We renamed the module; so this needed a reroll, I also fixed both remarks made in #5 by @Xano. Thanks!

borisson_’s picture

Status: Active » Postponed
Related issues: +#2629640: Configuration schema aliases
Xano’s picture

#2543420: Add schemas for core plugins' configuration should solve this. We need confirmation from Alex Pott and Gábor Hojtsy that such completely dynamic schema types do not come with any side effects.

Xano’s picture

Status: Postponed » Active

#2624860: Integration with the plugin project has committed integration by renaming the schemas. What shall we do here?

borisson_’s picture

Status: Active » Fixed

  • borisson_ committed 6f1aa3a on 8.x-1.x
    Issue #2616108 by borisson_, Xano: Integration with the plugin project
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.