!placeholders no longer valid [#2616064]

Since https://www.drupal.org/node/2575819 went in exclamation mark "!" placeholders are no longer supported and results in an error.

Patch to follow.

Comment	File	Size	Author
#2	youtube-placeholder-2616064-2.patch	766 bytes	msmithcti
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

16 November 2015 at 08:03

splatio created an issue. See original summary.

Comment #2

msmithcti CreditAttribution: msmithcti as a volunteer and commented 16 November 2015 at 08:05

Status:

Active

» Needs review

File	Size
youtube-placeholder-2616064-2.patch	766 bytes

Switching this to an "@" placeholder which ensures it is escaped.

As far as I can tell, now escaping this value doesn't seem to cause any issues.

Comment #3

17 November 2015 at 04:44

guschilds committed 2674fde on 8.x-1.x authored by splatio

Issue #2616064 by splatio: !placeholders no longer valid

Comment #4

guschilds CreditAttribution: guschilds at Chromatic commented 17 November 2015 at 04:47

Status:

Needs review

» Fixed

Thanks for the link to the issue and your patch. I've confirmed that it works without throwing an error. I don't think there would be a valid YouTube video ID that would be improperly displayed after being ran through "@", so this should be sufficient. I've committed it to the 8.x-1.x branch. Thanks again!