Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Francewhoa created an issue. See original summary.

intrafusion’s picture

Status: Active » Needs work
m.lebedev’s picture

I try to make a working version of the module for drupal 8.
The main functions work already.

m.lebedev’s picture

FileSize
35.74 KB

This patch is true

intrafusion’s picture

Title: Port "Job Scheduler" to Drupal 8 » Drupal 8 port

Thanks for the patch, this has been applied to the dev branch

m.lebedev’s picture

Great! I will add new changes here if there will be.

Francewhoa’s picture

Issue summary: View changes
Related issues: +#2606884: [job_scheduler] Job Scheduler

Thanks for your contributions m.lebedev and intrafusion :)

Francewhoa’s picture

@Francewhoa :) Note to myself. Updated ticket attribution.

m.lebedev’s picture

Changelog:
- Removed QueueWorker;
- Fixed "periodic" value save;
- Fixed a period to dispatch scheduled jobs;
- Fixed an info for log;
- Added the ability to create queues and to set a worker callback.

intrafusion’s picture

Issue summary: View changes

The new patch has been applied to the dev branch

m.lebedev’s picture

Changelog:
- Fixed records updating in the database. Before: A new record was creating, if it did not exist.

intrafusion’s picture

Again, this patch has been applied to the dev branch

m.lebedev’s picture

Status: Needs work » Needs review
FileSize
7 KB

Changelog:
- Logger adds information if there is one;
- Replaced the invoking queues. Added the derivative and the queue worker. Now it compatible with the queue_ui module;
- Changed API documentation for hooks.

And.. it's all. I a lot of time thinked about realize queues, but I decided to leave everything as it is (from D7). If you have any ideas how to improve the module, then I will be glad if help is provided. For example, refactoring and writing documentation.
I think this module is almost finished.
Thanks.

Status: Needs review » Needs work

The last submitted patch, 16: job_scheduler-drupal8_port-2615256-16.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

m.lebedev’s picture

Status: Needs work » Needs review
FileSize
9.78 KB

Applied the codesniffer_fixes.patch

Status: Needs review » Needs work

The last submitted patch, 18: job_scheduler-drupal8_port-2615256-18.patch, failed testing. View results

intrafusion’s picture

Issue tags: +Needs tests coverage

Once again thanks m.lebedev for your work on the port, if you think the module is almost finished then is it time to create an alpha/beta release?

I think any new features/improvements should be handled in separate issues so we can get this port out ASAP. The test bot will always fail as there is no test coverage and to my mind would be the only release blocker.

intrafusion’s picture

@Francewhoa you initially stated:

We would be happy to contribute testing patch, quality assurance, documentation, and agile project management services if needed

If this is still on offer then I think now would be the time for this to kick in.

m.lebedev’s picture

I think that we can wait about 2 weeks and after that to create an alpha release.
I use this module in my project now. I will report here about errors of the module if they occur. If not, then release!

intrafusion’s picture

Status: Needs work » Needs review
FileSize
1.75 KB

I have added some very simple tests (taken from Drupal 8: Writing Your First Unit Test With PHPUnit) which will hopefully satisfy the testbot and can be added to as necessary.

andypost’s picture

Looking at current interface \Drupal\job_scheduler\JobSchedulerInterface it require better naming for methods then it makes sense to implement unittest for \Drupal\job_scheduler\JobScheduler

m.lebedev’s picture

Is time to create an alpha release?

intrafusion’s picture

Status: Needs review » Fixed

Alpha release has been created and this issue marked as Fixed.

Any bugs can reported separately to this issue, thanks for all your help

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xjm’s picture

Issue tags: -needs tests coverage