Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The are some misspelled words in the info.ymls.
Comment | File | Size | Author |
---|---|---|---|
#16 | correct_admin_toolbar_info-2614962-16.patch | 949 bytes | dbt102 |
#16 | Final_Screen Shot 2016-04-23 at 12.50.53 AM.png | 51.54 KB | dbt102 |
#9 | correct_admin_toolbar_info-2614962-9.patch | 952 bytes | chegor |
| |||
#5 | correct_admin_toolbar_info-2614962-5.patch | 689 bytes | neha.gangwar |
minor_changes_to_info_ymls.patch | 1.25 KB | seppelM | |
|
Comments
Comment #2
seppelM CreditAttribution: seppelM commentedComment #4
Anonymous (not verified) CreditAttribution: Anonymous at Ashday Interactive Systems commentedSeems like a duplicate of 2615476, or vice versa.
Comment #5
neha.gangwar CreditAttribution: neha.gangwar as a volunteer commentedComment #6
neha.gangwar CreditAttribution: neha.gangwar as a volunteer commentedComment #8
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commentedThe maintainer (eme) closed the other issue as a duplicate of this one.
The patch in #5 has a few problems:
The sub-module's info file also has spelling mistakes.
Comment #9
chegor CreditAttribution: chegor as a volunteer commentedImproved patch
Comment #10
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commentedLooking better chegor <8•)
The drupal.org packaging info has been cleared out.
Updates descriptions of main module and submodule info files.
Improves, transforms, fonctionalities typos fixed.
Removes unrcessary repetition of the module name.
Comment #11
jmev CreditAttribution: jmev commentedI just installed it on a local D8 site and the description reads "Admin Toolbar Extra Tools adds more fonctionalities in the admin menu.", so perhaps a global find/replace of "fonctionalities" would help resolve all occurrences.
Comment #12
klonosThe last patch changes the text to "Improves the default administration menu and transforms it into a drop down menus." Either the "a" is superfluous or it should be "a drop down menu" (no plural for the word "menu"). Also, the norm is "drop-down" (with a hyphen). The rest of the variations are simply "acceptable" alternatives of "drop-down".
Comment #13
dbt102 CreditAttribution: dbt102 commentedI use this module so much, this issue was kind of 'bugging' :-) me.
I applied the ...62-9.patch to a "git clone --branch 8.x-1.x https://git.drupal.org/project/admin_toolbar.git" pulled today, then grabbed a screen shot so you can see ...
what it looked like to start (see attached file "Admin_Toolbar_62-9.patch Screen Shot 2016-04-21 at 2.32.30 PM"
I made a couple changes to make descriptions a little clearer, and especially address @klonos #12 comment above.
see ..
What it looks like per my updates (see attached file "Admin_Toolbar_NOW_Screen Shot 2016-04-21 at 2.37.21 PM"
Rolled new patch of what it looks like NOW for testing.
Comment #14
dbt102 CreditAttribution: dbt102 commentedooops ... my _62-13.patch is NOT correct.
After I posted it, then looked at the screenshots of before and after it seemed to me it could still be better. I went looking to see if I could find what the 'standard' actually is. Just by looking at the short descriptions provided by any number of modules on a particular site, its easy to see that some fall into a kind of 'rythm'.
Looks like the best guidance is here --> https://www.drupal.org/node/632280
So I would propose this wording...
"Adds drop-down menus to the core Drupal Toolbar."
I'll roll that patch in a few minutes.
Comment #15
dbt102 CreditAttribution: dbt102 commentedok ...
changed the file admin_toolbar.info.yml to "Provides a drop-down menu interface to the core Drupal Toolbar."
changed the file admin_toolbar_tools.info.yml to "Adds additional functionality to the admin menu."
see attached screenshot file --> Revised Screen Shot 2016-04-23 at 12.30.59 AM.png
I think I'm satisfied with that :-)
Comment #16
dbt102 CreditAttribution: dbt102 commentedOh crap ... #15 is not right either.
It should look like this --> Final_Screen Shot 2016-04-23 at 12.50.53 AM.png
Comment #17
dbt102 CreditAttribution: dbt102 commentedComment #18
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commentedComment #19
chegor CreditAttribution: chegor as a volunteer commentedI don't think that variant from #15 is better than in #9
Comment #20
dbt102 CreditAttribution: dbt102 commentedThanks for your comment #19 @chegor . Please let me explain why I proposed the variant of #16 vs #9
for name: Admin Toolbar
#9 patch --> "Improves the default administration menu and transforms it into a drop down menus."
1. The grammar of the last several words "... it into a drop down menus" is not correct.
If that phrasing is used it should be either "... it into a drop down menu" or "... it into drop down menus".
2. Admin Toolbar does not really "improve" the Drupal core Toolbar module so much as it improves the user experience when interacting with Toolbar.
3. The Admin Toolbar does kind of "transform" the 'admin' user experience.
4. The reference to "the default administration menu" should be to that of a proper noun, which in this case is the "Drupal" core "Toolbar", or the core "Drupal Toolbar", or the core "Toolbar" or I think just "Toolbar" would be correct. My preference is for "Drupal Toolbar" because if I search for that on Google its the #1 item. Whereas if I search for just "Toolbar" on google, the number 1 result is for the Google Toolbar.
#16 patch --> "Provides a drop-down menu interface to the core Drupal Toolbar."
Comment #22
romainj CreditAttribution: romainj commentedPatch in #16 has been committed.
Comment #23
romainj CreditAttribution: romainj commentedComment #29
dbt102 CreditAttribution: dbt102 commentedClosing out this issue since the patch has been committed