Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Working on removing of unused variables and adding @return
in the code base.
Comment | File | Size | Author |
---|---|---|---|
#6 | codingstandard-2614822.patch | 134.53 KB | saradaprasad17 |
#2 | 2614822-2.patch | 1.75 KB | heykarthikwithu |
Comments
Comment #2
heykarthikwithuAdded @return type.
removed the unused variables.
Comment #3
heykarthikwithuComment #4
mikeker CreditAttribution: mikeker as a volunteer commentedWhile these are legitimate cleanup items (and unused variables is just sloppy coding!), I want to keep the divergence of the 7.x and 8.x branch to a minimum. I'm happy to entertain these fixes in the 8.x branch (though you should probably wait a bit until it stabilizes).
Thanks.
Comment #5
mikeker CreditAttribution: mikeker as a volunteer commentedBEF now has an alpha release for D8.
Comment #6
saradaprasad17 CreditAttribution: saradaprasad17 at Valuebound commentedApplied Coding Standard for the below file.
src/Plugin/views/BetterExposedFilters.php
Attaching the patch file .
Comment #7
saradaprasad17 CreditAttribution: saradaprasad17 at Valuebound commentedComment #8
Neslee Canil PintoWe are trying to deprecate 8.x-3.x, can you please check whether this still exists in 8.x-4.x/8.x-5.x branch.