Working on removing of unused variables and adding @return in the code base.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

heykarthikwithu created an issue. See original summary.

heykarthikwithu’s picture

Assigned: heykarthikwithu » Unassigned
Priority: Normal » Minor
Status: Active » Needs review
FileSize
1.75 KB

Added @return type.
removed the unused variables.

heykarthikwithu’s picture

Issue tags: +unused variables, +Quick fix
mikeker’s picture

Version: 7.x-3.x-dev » 8.x-3.x-dev
Status: Needs review » Postponed

While these are legitimate cleanup items (and unused variables is just sloppy coding!), I want to keep the divergence of the 7.x and 8.x branch to a minimum. I'm happy to entertain these fixes in the 8.x branch (though you should probably wait a bit until it stabilizes).

Thanks.

mikeker’s picture

Status: Postponed » Active

BEF now has an alpha release for D8.

saradaprasad17’s picture

Assigned: Unassigned » saradaprasad17
Issue tags: +applied coding standard
FileSize
134.53 KB

Applied Coding Standard for the below file.
src/Plugin/views/BetterExposedFilters.php
Attaching the patch file .

saradaprasad17’s picture

Status: Active » Needs review
Neslee Canil Pinto’s picture

Status: Needs review » Closed (won't fix)

We are trying to deprecate 8.x-3.x, can you please check whether this still exists in 8.x-4.x/8.x-5.x branch.