Working on adding a missing parameter on documentation part

CommentFileSizeAuthor
#2 2614578-2.patch657 bytesxaiwant
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

xaiwant created an issue. See original summary.

xaiwant’s picture

xaiwant CreditAttribution: xaiwant as a volunteer and at Valuebound commented
Assigned: xaiwant » Unassigned
Status: Active » Needs review
FileSize
2614578-2.patch657 bytes

Applied patch for missing @argument in a documentation section.

nico.knaepen’s picture

nico.knaepen CreditAttribution: nico.knaepen at Logic in Motion for Colruyt Group Services commented
Status: Needs review » Needs work

@xaiwant the patch is not working for the current sandbox version.

The folder structure is now PSR-4 compliant and does not start with /lib anymore. You should pull the latest version and apply your changes on here. The functions you have updated the comments for are also moved to the submodule scrambler_field. You could make the changes there instead. Once they are done, i will add your patch.

Already a big thank you for helping me to get this module ready.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Status: Needs work » Needs review

Can you check once again, because the patch is being applied.

refer this.

vb76-Presario-CQ42 modules # git clone --branch 8.x-1.x http://git.drupal.org/sandbox/nicoknaepen/2604716.git scrambler
Cloning into 'scrambler'...
remote: Counting objects: 208, done.
remote: Compressing objects: 100% (162/162), done.
remote: Total 208 (delta 88), reused 0 (delta 0)
Receiving objects: 100% (208/208), 27.99 KiB | 0 bytes/s, done.
Resolving deltas: 100% (88/88), done.
Checking connectivity... done.
vb76-Presario-CQ42 modules # cd scrambler/
vb76-Presario-CQ42 scrambler # wget https://www.drupal.org/files/issues/2614578-2.patch
--2015-11-13 17:24:28--  https://www.drupal.org/files/issues/2614578-2.patch
Resolving www.drupal.org (www.drupal.org)... 103.245.222.68
Connecting to www.drupal.org (www.drupal.org)|103.245.222.68|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 657 [text/plain]
Saving to: ‘2614578-2.patch’

100%[==============================================================================================================================>] 657         --.-K/s   in 0s      

2015-11-13 17:24:30 (92.6 MB/s) - ‘2614578-2.patch’ saved [657/657]

vb76-Presario-CQ42 scrambler # git apply -v 2614578-2.patch
Checking patch lib/Drupal/scrambler/BLL/API.php...
Applied patch lib/Drupal/scrambler/BLL/API.php cleanly.
vb76-Presario-CQ42 scrambler #
nico.knaepen’s picture

nico.knaepen CreditAttribution: nico.knaepen at Logic in Motion for Colruyt Group Services commented
Status: Needs review » Needs work

We are currently only focusing on 7.x-1.x. Only after delivery of this release we will start with the 8.x-1.x release. So for now no changes will be done in the 8.x-1.x branch.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Status: Needs work » Postponed