It would be nice if:
1) there was an option to upload a logo instead of just putting in a URL
2) there was an option for NO logo
3) there was an option for the site name and/or some custom phrase.

I haven't seen the Drupal 6 version, so I don't know if you've added these already. Just a thought.

Anisa.

Comments

jcnventura’s picture

jcnventura CreditAttribution: jcnventura commented
Status: Active » Closed (works as designed)

Hi,

All of what you asked can be done easily without changing anything..

1) You can upload a file to your site (there are several mechanisms for this) and then use that file's URL.
2) There are several options for no logo:
a) If you don't specify a custom logo, it will use your current theme's logo. If you don't use a logo in your theme, the print page will not use a logo also.
b) You can edit the print.tpl.php and remove the logo line. You can place this in your theme's dir if you want the file to survive upgrades of the module.
3) You can change any of the strings that are used in the template via the theme_print_text() function.

I don't want to clutter the settings page with stuff that only matters to a few users, so if you want to be a power user you must use the power features.

João

rivena’s picture

rivena CreditAttribution: rivena commented

That's certainly one way of viewing it. I'm not sure that not wanting my logo on the print page makes me a power user, but I did find a way around it, thank you for your detailed list of options. I'm sure that will help other people in a similar situation.

Anisa.

jcnventura’s picture

jcnventura CreditAttribution: jcnventura commented
Status: Closed (works as designed) » Postponed

You're probably right about the power user part... At least for the 'no logo' option. ;)

I will maybe change it to a radio selection with three options: 1) No logo, 2) Current Theme logo and 3) logo speciefied in logo URL.

I will keep that in my todo list.

As for changing the strings.. That's definitively a power user area.. So theme_print_text() and edit the template all that you need.

João

jcnventura’s picture

jcnventura CreditAttribution: jcnventura commented
Status: Postponed » Fixed

Hello,

After 2 months, I have (finally) added the code to select whether to use the theme logo, a user defined logo or none. I have also added the capability of uploading the logo..

This is only in the D6 branch for now..

João

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.