video filter button/icon stopped working [#2613008]

I finally got video filter module to work on Drupal 7 with CKeditor only combination. By adding the code mentioned in the readme text file and copying the ckeditor folder from video filter module into ckeditor module. So the blue icon for video filter was showing and got added to the 'full html' toolbar, all of a sudden now clicking the icon/button does not open the dialog box with video URL and width and height settings anymore.
The video filter functionality is there and working if I type in [video:...], but not sure how to fix the window to pop up again.
Thanks.

Comments

Comment #1

10 November 2015 at 23:52

sin@ created an issue. See original summary.

Comment #2

sin@ CreditAttribution: sin@ as a volunteer commented 11 November 2015 at 15:46

Issue summary:

View changes

Comment #3

laso25 CreditAttribution: laso25 commented 11 November 2015 at 21:54

The problem is that the module is calling a function that is deprecated...

https://developer.mozilla.org/en-US/docs/Web/API/Window/showModalDialog

video_filter/editors/ckeditor/plugin.js

window.showModalDialog(path, { 'opener' : window, 'editorname' : editor.name }, "dialogWidth:580px; dialogHeight:480px; center:yes; resizable:yes; help:no;");

I'm trying to fix it ASAP, having to rewrite everything (the plugin.js and the video_filter_dialog.js), and then I'll send a patch.

Comment #4

sin@ CreditAttribution: sin@ as a volunteer commented 19 November 2015 at 20:40

Thanks a lot that would be very helpful.
I managed to make it finally work by removing everything and turning off the module and then start from scratch and it started working again.
Also the readme file with the module asks for adding a few lines of code to the js file but I have seen newer comments from other members that using the latest version on drupal 7 does not need those lines anymore, if that is true, it would be great if that text file can also be updated so next person who is installing it would know for sure.
Is there anyway through this module that we can embed our video without showing a link to the original host (making sure user does not go away)?