Forward port submission improvements (#ief_element_submit) to D8

This needs to be our biggest IEF priority, otherwise we'll need to keep adding band-aids for bugs the D7 version doesn't have.

I just taken a good look at http://cgit.drupalcode.org/inline_entity_form/diff/?id=a754ba7
Which the commit for the referenced issue.

It looks to me like most if not all of the logic for that patch is already in 8.x-1.x.

Ok uploading a patch that fixes some remaining submissions.

I wasn't sure if I should post it here or #2626970: Add testcase for nested inline entity form

This patch does get all of those test passing up to this point on the issue:
https://www.drupal.org/node/2626970#comment-10826306

I have upload this patch I will add another comment explaining some of the changes

+++ b/src/Element/InlineEntityForm.php
@@ -256,4 +258,52 @@ class InlineEntityForm extends RenderElement {
+  public static function addSubmitCallbacks(&$element) {
+    $element['#submit'] = [
+      ['\Drupal\inline_entity_form\Element\InlineEntityForm', 'triggerIefSubmit'],
+      ['\Drupal\inline_entity_form\Element\InlineEntityForm', 'closeForm'],
+    ];
+    $element['#ief_trigger']  = TRUE;
+  }
+

Create addSubmitCallBacks because this same two function were being added in multiple places in this manner.

I also added #ief_trigger as a way to know which elements should trigger IEF saves so that isSubmitRelevant could be much simplier.

+++ b/inline_entity_form.module
@@ -258,16 +239,6 @@ function inline_entity_form_open_row_form($form, FormStateInterface $form_state)
-function inline_entity_form_close_child_forms($form, &$form_state) {

Moved this function to static function on \Drupal\inline_entity_form\Element\InlineEntityForm

This could probably be done with more functions to remove code from .module file

+++ b/inline_entity_form.module
@@ -530,3 +501,14 @@ function inline_entity_form_pre_render_add_fieldset_markup($form) {
+/**
+ * Implements hook_form_alter().
+ */
+function inline_entity_form_form_alter(&$form, FormStateInterface &$form_state, $form_id) {
+  if ($form_state->get('inline_entity_form')) {
+    InlineEntityForm::attachMainSubmit($form);
+  }
+
+}
diff --git a/src/Element/InlineEntityForm.php b/src/Element/InlineEntityForm.php

This was not ported from D7 before. This ensures that main submit button gets the IEF callbacks.

Relying on AJAX callbacks to do this doesn't seem to work.

+++ b/src/Element/InlineEntityForm.php
@@ -153,6 +153,7 @@ class InlineEntityForm extends RenderElement {
+      $complete_form['submit']['#ief_trigger']  = TRUE;

Ensuring that parent form buttons are marked as IEF triggers.

+++ b/src/Plugin/Field/FieldWidget/InlineEntityFormBase.php
@@ -411,25 +411,8 @@ abstract class InlineEntityFormBase extends WidgetBase implements ContainerFacto
   protected function isSubmitRelevant(array $form, FormStateInterface $form_state) {
-    $field_name = $this->fieldDefinition->getName();
-    $field_parents = array_slice(array_merge($form['#parents'], [$field_name, 'form']), 0, -1);
-
     $trigger = $form_state->getTriggeringElement();
-    if (isset($trigger['#limit_validation_errors']) && $trigger['#limit_validation_errors'] !== FALSE) {
-      $relevant_sections = array_filter(
-        $trigger['#limit_validation_errors'],
-        function ($item) use ($field_parents) {
-          $union = $field_parents + $item;
-          return $union == max(count($item), count($field_parents));
-        }
-      );
-
-      if (empty($relevant_sections)) {
-        return FALSE;
-      }
-    }
-
-    return TRUE;
+    return !empty($trigger['#ief_trigger']);

Because of #ief_trigger we can remove this logic and just check if it is a trigger.

+++ b/src/Plugin/Field/FieldWidget/InlineEntityFormComplex.php
@@ -611,19 +612,24 @@ class InlineEntityFormComplex extends InlineEntityFormBase implements ContainerF
-      foreach ($values as $delta => &$item) {
-        /** @var \Drupal\Core\Entity\EntityInterface $entity */
-        $entity = $item['entity'];
-        if (!empty($item['needs_save'])) {
-          $entity->save();
-        }
-        if (!empty($item['delete'])) {
-          $entity->delete();
-          unset($items[$delta]);
+      $trigger = $form_state->getTriggeringElement();
+
+      if (!empty($trigger['#ief_submit_all'])) {
+        foreach ($values as $delta => &$item) {
+          /** @var \Drupal\Core\Entity\EntityInterface $entity */
+          $entity = $item['entity'];
+          if (!empty($item['needs_save'])) {
+            $entity->save();
+          }
+          if (!empty($item['delete'])) {
+            $entity->delete();
+            unset($items[$delta]);
+          }

We should not actually be doing the saves or deletes until the main parent submit button is submitted(checked via #ief_submit_all)

This from my understanding that entities should only be saved with the main form.

This is great! Golden star!

Ok here is another patch that makes a small change in \Drupal\inline_entity_form\Form\EntityInlineForm::entityFormValidate to make sure validation is only run on an entityform if the submission was trigger by the current IEF element.

This will allow one of the "required" tests in #2626970: Add testcase for nested inline entity form that is currently commented out to pass.

It also fixes part of #2649710: Required nested IEF forms don't work it allows fields that are required to work but only if you submit the forms via ajax NOT leave them open.

Ok my 8.x-1.x was behind locally

The interdiff is still against #7