Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.This depends on this layout_plugin issue #2490680: Allow layouts to provide settings.
That issue basically makes is it so that LayoutInterface also extends ConfigurablePluginInterface and PluginFormInterface so that layouts can provide settings forms and accept configuration.
This issue is mostly about Display Suite using the new APIs for settings to manage it's layout settings. This then allows other systems (like Panels) to use the Display Suite layouts and get all the necessary configuration forms, and for Display Suite to use other layouts and pull in their configuration forms (not using the Display Suite ones).
I've tested using page_manager with block_page_layout (an example included with layout_plugin) to successfully use the Display Suite layouts in page_manager.
And I've tested using Display Suite with the "Test layout (with settings)" from the layout_plugin_example module, and that also worked successfully!
Assuming I have this patch right, it also shouldn't change anything in the UI for Display Suite users using Display Suite layouts.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | ds-layout-settings-2612040-8.patch | 39.69 KB | dsnopek |
Comments
Comment #2
dsnopekHere is the patch! Please let me know what you think :-)
Comment #3
aspilicious CreditAttribution: aspilicious commentedI'm working on getting all the tests green first to ensure we have a working testbot for the 8.x branch :)
Comment #4
dsnopek@aspilicious: That's great, thanks! While all I really did was move code around, I'll feel much more comfortable about my changes once we can run the tests on them. :-)
Comment #6
dsnopekLooks like this needs a reroll! I'll try to take a look at it early next week.
Comment #7
aspilicious CreditAttribution: aspilicious commentedThnx, I want to get this in before the 8.0.0 release :)
Comment #8
dsnopekMe too. :-)
Here's a re-roll of the patch!
Running the tests locally on both the unmodified 8.x-2.x branch and with the patch, I'm getting 3 failures from EntityTest. I'm not sure if it's some local environment issue, but I'm curious to see if they happen on testbot too... Otherwise, it's passing all the other tests for me locally!
Comment #9
dsnopekWoohoo, tests are passing! The EntityTest failures must have been some issue with my local environment. :-)
Comment #11
aspilicious CreditAttribution: aspilicious commentedDid some minor changes, but...
THANK YOU SO VERY MUCH!
Comment #12
dsnopekHuzzah! Thanks for reviewing and committing so quickly! We've finally achieved the "layout plugin dream" for Panels and DS :-)
Comment #13
pfrenssenWow, really nice! Didn't see this one coming. Thanks a lot!!
Comment #14
andypostI found no dependency on the module, great!!!