If inline entity is newer (changed more recentry) then node - validation fails

This seems like duplicate of #2609020: Unable to reedit entity in a single request. Can you check?

That other issue also happens with only one field. It was mentioned in a comment. Title was confusing. Fixed it.

Patch in that issue was committed. You can check if you still see this error with the latest HEAD.

The error is not related to the other ticket, we have both issues in our project. First one is fixed, will now test this patch if it helps :)

Now I was able to reproduce. What about something like this? This patch removes all values that are not relevant for this specific IEF instead of just hardcoding one specific field name.

I think we will also need some test coverage for this.

+++ b/src/InlineEntityForm/EntityInlineEntityFormHandler.php
@@ -288,7 +290,15 @@ class EntityInlineEntityFormHandler implements InlineEntityFormHandlerInterface
+    $form_state_values = array_filter(
+      $form_state->getValues(),
+      function ($key) use ($parents) { return $key == $parents[0]; },
+      ARRAY_FILTER_USE_KEY
+    );

Third argument to array_filter is PHP 5.6 feature. Question is if we want to require 5.6 or not.

Hm... I can't reproduce this any more. I noticed this bug in slightly different situation than the one described in the summary:

1. Create content type A
2. Create two media bundles B and C
3. Configure nested complex IEF (A => B => C) - both references are multivalue ER fields
4. Create content of type A, add one media B and add few C on it.
5. Try to edit one of C media items
6. Boom!

However, I can't reproduce it any more. I also can't reproduce with steps from issue summary. Can anybody else reliably recreate this error in isolation?

Also can't reproduce issue. Here is a test only patch with the steps from the summary.

I was also no more able to reproduce since it is a lot of clicking, but I was still sure it may happen. The test of Denchev was missing the actual testing if the second edit attempt is working.

Here is a rewrite of the test, it is also now proving that the issue still exists. I also attached a working version of patch from #9, it is actually fixing the problem! :)

So let see what the test bot says!

Here a new version which should pass in PHP 5.5

I am pretty sure it's all fine. The PostgreSQL test was failing for every patch here in the issue. Looks like an error in the test bot for me, does someone know more?

Yeah... Postgres test is failing quite often. I am pretty sure those fails are not related. I have just few cosmetic comments.

1. +++ b/src/Tests/InlineEntityFormComplexWebTest.php
   @@ -325,20 +325,83 @@ class InlineEntityFormComplexWebTest extends WebTestBase {
   +   *
   +   * @see https://www.drupal.org/node/2611956
   +   */
   

   Do we really need to link the issue?

2. +++ b/src/Tests/InlineEntityFormComplexWebTest.php
   @@ -325,20 +325,83 @@ class InlineEntityFormComplexWebTest extends WebTestBase {
   +    // Edit node to reference.
   

   "Edit referenced node."?

3. +++ b/src/Tests/InlineEntityFormComplexWebTest.php
   @@ -325,20 +325,83 @@ class InlineEntityFormComplexWebTest extends WebTestBase {
   +    // Edit node to reference.
   

   "Edit referenced node."?

@axe312 tanks for fixing the test.

addressed #31

Changes of Denchev look good. Thx!

I spoke with @bojanz and we agreed that we commit this and hopefully find a nicer solution later. It fixes a real problem which is enough for now.

Thank you everyone!