In trying to update various Actions and Conditions to use doExecute() and doEvaluate(), the tests for the ones with optional context values fail. This is because the optional values don't have a default value set in the context annotation, to prevent execute() and evaluate() from sending NULL as the default value.

Comments

emclaughlin created an issue. See original summary.

emclaughlin’s picture

emclaughlin CreditAttribution: emclaughlin at Genuine commented
Assigned: emclaughlin » Unassigned
Status: Active » Needs review

PR here: https://github.com/fago/rules/pull/286

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago at drunomics commented
Status: Needs review » Needs work

I see - thanks. The PR needs a re-roll though.

jjchinquist’s picture

jjchinquist CreditAttribution: jjchinquist as a volunteer commented
Assigned: Unassigned » jjchinquist
jjchinquist’s picture

jjchinquist CreditAttribution: jjchinquist as a volunteer commented
Assigned: jjchinquist » Unassigned
Status: Needs work » Needs review

Resolved conflict
https://github.com/fago/rules/pull/303

  • klausi committed d881a1e on 8.x-3.x authored by jjchinquist 
    Issue #2611942 by emclaughlin, jjchinquist: Added context default values...
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Needs review » Fixed

merged, thanks!

@jjchinquist: your git email address is messed up: Jeremy Chinquist
See https://www.drupal.org/node/1022156

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.