Mail users when their account is blocked

This all seems like an improvement. One thought:

+      if (user_save($account, array('status' => 0)) !== FALSE) {

Now that's inside an if, it seems good to have an "else" case that will log an error to watchdog and do a drupal_set_message. Can you provide that?

Hi bhavikshah9, it would help rtbc if you could provide an automated test for this feature.

Any chance you have time to do that?

I did a more thorough code-level review and found some items that seem ideal to fix.

Thanks for all your work so far. I think this is really close!

1. +++ b/user_expire.module
   @@ -278,11 +278,21 @@ function user_expire_expire_users(array $accounts) {
   +        // User account has expired, status set to '0'
   

   Missing punctuation on the end of the line.

2. +++ b/user_expire.module
   @@ -278,11 +278,21 @@ function user_expire_expire_users(array $accounts) {
   +        watchdog('user_expire', 'Cannot update status for User %name.', array('%name' => $account->name));
   

   I think it's more common to leave "User" lower case in the middle of the sentence. Also, the default watchdog severity level is a notice, but this seems more important than that. WATCHDOG_ERROR or WATCHDOG_CRITICAL seem more appropriate to me.

3. +++ b/user_expire.module
   @@ -473,4 +483,19 @@ function user_expire_mail($key, &$message, $params) {
   +    $message['body'][] = t('We have written this email to inform you that, your account at @site_name is blocked.',
   

   I think the comma in this line is not grammatically correct. I suggest removing it.

4. +++ b/user_expire.test
   @@ -4,29 +4,46 @@
   +    $this->assertTrue($this->basic_account->status, t('User account is currently enabled.'));
   

   Thanks for all the code cleanup and for adding tests for this new code!

Thanks for the work!

This is now committed.