Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
As stated in
https://www.drupal.org/licensing/faq#q7
All the code in the repo must be licensed under GPLv2 or later.
Probably this code should be downloaded as a library to avoid legal problems
Related issue:
#2608312: Non-GPL code at apiRedsys.inc
Comments
Comment #3
turtulino CreditAttribution: turtulino commentedHi Rodrigo
You are right. I did not realize the copyright notice in RedsysAPI class.
I have replaced it with a compatible custom class in 6.x version. I will port it to 7.x version as soon as possible.
In the future, it would be interesting to replace it with an external library (like https://github.com/CommerceRedsys/sermepa ) but in the short term I'm too busy and this should work in no time.
Comment #5
turtulino CreditAttribution: turtulino commentedI've replaced the problematic class by another one that does the same but without licensing issues.
Comment #6
ñull CreditAttribution: ñull as a volunteer commentedStatus changed to fixed which means the new class was included in 7.x-3.x-dev, right? Does that mean it is also tested by the community? I ask this because I don't see this reflected in the status changes here.
Comment #7
ñull CreditAttribution: ñull as a volunteer commentedComment #8
turtulino CreditAttribution: turtulino commentedHi Ñull
This issue relates to a legal problem because I have included a file from Redsys examples which have a proprietary license.
If I've deleted the file there is no legal problem so I think the issue is fixed.
There are two other open issues about SHA256 support:
I think the problems with SHA256 should be reported on these issues.