I found many errors in log generated on the Bootstrap Sub-Theme settings page. Patch attached.

CommentFileSizeAuthor
#5 2611770-5.patch13.79 KBmarkhalliwell
#3 2611770-3.patch12.29 KBchegor
fix-placeholders-errors.patch14 KBchegor
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chegor created an issue. See original summary.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Priority: Major » Normal
Status: Needs review » Needs work

Please rebase the patch against the latest code in 8.x-3.x.

chegor’s picture

chegor CreditAttribution: chegor as a volunteer commented
Status: Needs work » Needs review
FileSize
2611770-3.patch12.29 KB

rebased

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Component: Templates » Code
Assigned: Unassigned » markhalliwell
Status: Needs review » Needs work
Related issues: +#2578615: Links misconfiguration on theme settings -> general tab

Actually all !url placeholders need to be replaced with :url (change record).

Furthermore, the placeholders should just be links... not rendered links. The translation strings should contain <a href=":url">Link</a>.

This related issue is the culprit for changing how these were constructed, I'll fix this.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Assigned: markhalliwell » Unassigned
Status: Needs work » Needs review
FileSize
2611770-5.patch13.79 KB

p.s. we don't need the jQuery Update warning suppression setting so it can just be removed

  • markcarver committed 9dd6b08 on 7.x-3.x 
    Issue #2611770 by chegor, markcarver: Errors User error: Invalid...
markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented

Just compared the 7.x-3.x branch and found a few inconsistencies there too (#6).

edit: leaving as CNR so you can review the 8.x-3.x changes before I commit

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Needs review » Fixed
Commit a1afa8a on 8.x-3.x

  • markcarver committed ff5ebc9 on 8.x-3.x 
    Issue #2611770 by chegor, markcarver: Errors User error: Invalid...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.