Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
This happens on a month views when mini calendar is selected + week numbers are being shown.
Comment | File | Size | Author |
---|---|---|---|
#4 | interdiff-2610934-2-4.txt | 1.56 KB | geertvd |
#4 | 2610934-4.patch | 1.84 KB | geertvd |
#2 | 2610934-2.patch | 1.96 KB | geertvd |
Comments
Comment #2
geertvd CreditAttribution: geertvd at XIO commentedThis gives us a link to a week view of the clicked week. The week view is still throwing an error, but that's a separate issue.
Right now I'm using
Url::fromUri('base:' . $path ....
which should be avoided, for that purpose I think we should rewritecalendar_granularity_path()
to return a route rather then a path, I created a follow-up issue for that #2610940: calendar_granularity_path() should be rewritten to return a URL Object rather then a pathComment #3
geertvd CreditAttribution: geertvd at XIO commentedCreated another follow-up for that #2610942: Fatal error thrown when adding a filter value in week view/day view
Comment #4
geertvd CreditAttribution: geertvd at XIO commentedI also did some research on
$options = ['query' => !empty($this->styleInfo->append) ? $this->styleInfo->append : ''];
. This seems to be legacy code as it's unused in 7.x also. Let's just remove that so.Comment #5
geertvd CreditAttribution: geertvd at XIO commentedComment #7
Anonymous (not verified) CreditAttribution: Anonymous at XIO commentedAgreed that we shouldn't use
Url::fromUri()
, but this is good enough while refactoring. A follow-up for that is here: #2610940: calendar_granularity_path() should be rewritten to return a URL Object rather then a path.Committed.