Follow-up to #2610002: If facet source is empty, it's unclear for an end-user what to do.

Problem/Motivation

If the facet source field is empty, the Add facet button should not be present on the page because you can't continue anyway.

CommentFileSizeAuthor
#3 if_facet_source_is-2610854-3.patch1.3 KBborisson_
Screen Shot 2015-11-07 at 16.25.22.png112.61 KBNovitsh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Novitsh created an issue. See original summary.

Novitsh’s picture

Novitsh CreditAttribution: Novitsh at Colruyt Group Services commented
Issue summary: View changes
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Version: » 8.x-1.x-dev
Status: Active » Needs review
FileSize
if_facet_source_is-2610854-3.patch1.3 KB

Removing the button doesn't seem very easy, but I added the same message that we display on the overview in the edit form as well.

Novitsh’s picture

Novitsh CreditAttribution: Novitsh at Colruyt Group Services commented
Status: Needs review » Reviewed & tested by the community

Tested this and for me this is already a good step. Are we going to commit this already or are we going for the removal of the 'Add facet' and 'Save' buttons as well?

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks for the review.

  • borisson_ committed 93b1396 on 8.x-1.x 
    Issue #2610854 by borisson_: If facet source is empty, don't display Add...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.