Independent from we add new one or edit existing domain, I always see 'Domain record updated.' message.
That's because we have this code in domain_form_submit():

  if (!empty($values['domain_id']) || $values['domain_id'] == 0) {
    $message = t('Domain record updated.');
  }
  else {
    $message = t('Domain record created.');
  }

Second part of first condition will be true even in case of new domain.

CommentFileSizeAuthor
#2 fix-create-message-2610646-2.patch504 bytesIRuslan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

IRuslan created an issue. See original summary.

IRuslan’s picture

IRuslan CreditAttribution: IRuslan as a volunteer and at DrupalJedi commented
Status: Active » Needs review
FileSize
fix-create-message-2610646-2.patch504 bytes

Patch in attachment.

kjala’s picture

kjala CreditAttribution: kjala as a volunteer commented
Status: Needs review » Reviewed & tested by the community

I was able to replicate the stated problem on 7.x-3.11 version. I have tested the patch and the new domain record creation now shows the correct message. The previous OR condition $values['domain_id'] == 0 might be there to support default domain with ID 0 . Given that the domain id's are not zero's anymore, I think it can be removed.

unless any other reviewer or agentrickard finds something, I think this patch is good to go. Changing it to RTBC

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented
Status: Reviewed & tested by the community » Fixed

Correct on both counts. This might work if we used === 0, but it's no longer relevant.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.