Any plans for porting this module to Drupal 8? I'd be willing to help with an upgrade effort if needed.

Comments

ksenzee created an issue. See original summary.

taslett’s picture

Yes I am planning to upgrade it to Drupal 8, thanks any help is welcome.
I'm pretty tied up with other projects at the moment.

narendraR’s picture

Hi @taslett,

I am interested in porting this module. Are you working on D8 port of this module.

Thanks,
Narendra

taslett’s picture

Hi Narendra,
I haven't really had a chance lately to get into it.
Feel free to jump in if you want.

Regards
Tony

narendraR’s picture

Hi Tony,

Thanks for the reply. I will start working on this module and let you know once completed.

Thanks,
Narendra

narendraR’s picture

Status: Active » Needs review

Hi Tony,

I have created a sandbox module.
https://www.drupal.org/sandbox/narendra23/2724523

This module does not include any other module support for now(rules etc). Also I have removed move to top feature for now.
Please review and let me know your feedback on this.

Thanks,
Narendra

taslett’s picture

Hi Narendra,
Thanks for all the work you put in.
I probably won't get a chance to have a look till the weekend.
i will let you know how it goes.

narendraR’s picture

Hi Tony,

I will be happy to have your feedback and suggestions on the work done.

Thanks,
Narendra

taslett’s picture

Hi Narendra,
Nearly there well done.
Sorry it took so long for me to have a look.

I'm getting a few errors when saving a comment and trying to view a page with a comment:

Recoverable fatal error: Argument 2 passed to bestreply_comment_links_alter() must be an instance of CommentInterface, instance of Drupal\comment\Entity\Comment given, called in /Users/tonyaslett/Sites/drupal/d8/bestr/core/lib/Drupal/Core/Extension/ModuleHandler.php on line 501 and defined in bestreply_comment_links_alter() (line 80 of /Users/tonyaslett/Sites/drupal/d8/bestr/modules/best_reply/bestreply.module).

User error: Invalid placeholder (!bestreply) in string: Check the node types you want to be able to mark a comment as the !bestreply. in Drupal\Component\Render\FormattableMarkup::placeholderFormat() (line 233 of /Users/tonyaslett/Sites/drupal/d8/bestr/core/lib/Drupal/Component/Render/FormattableMarkup.php).

This was from a clean install of Drupal 8.1.1 with the standard profile and only the best reply module added.

Thanks for your help
Tony

narendraR’s picture

Hi Tony,

Thanks for the feedback. I will look into the issue and will update you.

Thanks,
Narendra

narendraR’s picture

Assigned: Unassigned » narendraR
narendraR’s picture

Status: Needs review » Needs work
narendraR’s picture

Assigned: narendraR » Unassigned
Status: Needs work » Needs review

Hi Tony,

I have fixed these issues. Please have a look when you get time.

Thanks,
Narendra

narendraR’s picture

taslett’s picture

Hi NarendraR,
Sorry for the slow reply, I am just back from holiday and will have a look shortly.

taslett’s picture

Hi Narendra,
That's looking much better.
Well done.
I've added you as a maintainer so feel free to add the D8 version.

narendraR’s picture

Hi Tony,

Thanks for making maintainer of this project. However I was not able to commit my sandbox code there. May be some git or permission related issue.
Can you please add my sandbox code to Bestreply module D8 branch.

Thanks in advance,
Narendra

taslett’s picture

Hi Narendra,
I've created a D* release based on your code.

Thanks for your help.

taslett’s picture

Status: Needs review » Closed (outdated)