Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Move the procedural helper functions to a manager. This is a previous step to add tests.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 2610208-6.patch | 20.07 KB | devkinetic |
Comments
Comment #2
ericduran CreditAttribution: ericduran at NBCUniversal commented+1 here.
Looking at the module now there's a lot of room for improvement. I'll see if I can find time to help here. I mostly came to this from a testing perspective.
Comment #3
fjgarlin CreditAttribution: fjgarlin as a volunteer and at Amazee Labs commentedEven though the issue is old, this is still applicable. I made an attempt to move all the helper functions into a service. Patch included. I tested the module and everything seemed to be working as expected.
Comment #4
devkinetic CreditAttribution: devkinetic commentedI had just created #3319167: Refactor Toolbar code to use a helper class + add per environment permissions and then found this. The patch in that issue applies to 4.x.
Comment #5
devkinetic CreditAttribution: devkinetic commentedHere is an updated patch, closing that other issue.
Comment #6
devkinetic CreditAttribution: devkinetic commentedThe previous patch had a missing service.
Comment #7
e0ipsoThis looks good! Thanks for the patch.