Problem/Motivation

Now when a sensor doesn't set the #query parameter as VerboseTableResult sets it to empty string when we check if query is empty always returns true.

Proposed resolution

We could initialize the #query to null, but as is possible that a sensor give us an empty string, I think the best option is to change the check to a !empty() instead of isset().
We have to do the same for #query_args that now works just because when we initialize it the name is incorrect.
Also we have to change that #arguments for #query_args.

Remaining tasks

User interface changes

API changes

Data model changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

edurenye created an issue. See original summary.

edurenye’s picture

Status: Active » Needs review
Parent issue: » #2603854: Create an own element for verbose data
FileSize
1.21 KB

Done.

miro_dietiker’s picture

Status: Needs review » Needs work

Committing this because i'm reviewing UI / UX improvements...

However, still needs work because we should add a assertNoText Query on a sensor that wrongly had it such as the user_integrity sensor.

edurenye’s picture

Status: Needs work » Needs review
FileSize
773 bytes

Added tests.

miro_dietiker’s picture

Status: Needs review » Fixed

Committed, thx.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.