Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#12 | interdiff.txt | 755 bytes | dawehner |
#12 | 2608994-12.patch | 4.82 KB | dawehner |
| |||
#10 | interdiff.txt | 5.05 KB | dawehner |
#10 | 2608994-10.patch | 4.81 KB | dawehner |
| |||
#8 | features-dependencies-2608994-9.patch | 3.94 KB | nedjo |
|
Comments
Comment #2
dawehnerHere is a quick patch.
Comment #3
dawehnerHere is also a test
Comment #4
nedjoThanks for the patch. And with a draft test too :)
'machine_name' is indeed incorrect. The dependency is on an existing exported feature, so the key we need here is 'package' (which tracks the package that provides the given piece of configuration) rather than 'name' (the name of the configuration item). For a bit more on what the config collection item keys represent, see the documentation to
FeaturesManagerInterface::getConfigCollection()
.I know the code is very hard to follow. We're trying to improve that in #2606926: Error "The following module is missing from the file system", #2595263: Remodel packages as objects, #2595265: Remodel configuration items in FeaturesManager::configCollection as objects, and #2569149: Use ConfigEntity for features bundles. Meanwhile, welcome to Features 3.x and thanks for helping fix things up!
Comment #5
nedjoBecause I had to rewrite the section of code with this bug, I ended up including a fix in #2606926: Error "The following module is missing from the file system" (see patch).
I'd love get the test in though, particularly because it helps model how we can write similar tests. Here's a redraft.
Comment #7
nedjoThis is slightly closer but not yet completing for me locally.
Comment #8
nedjoThis should pass, but only because I've removed an argument to
FeaturesAssigner::getBundle()
, suggesting a bug there.Comment #9
nedjoComment #10
dawehnerHere is one more detailed test, once with a once without a bundle.
Comment #12
dawehnerHa, you should not simply manipulate files before creating a patch.
Comment #14
nedjo@dawehner: committed. This helps model what we need to do in other unit tests. Thanks for the guidance!