Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Hi guys,
I have developed a small module for drupal 7 Image Captcha Refresh , I guess will be a good idea include this module into the CAPTCHA module as additional option, which will provide users use it from the box. If you are agree with this idea, I will prepare a patch which will include needed features. Also I can help with fixing bugs after that.
Thanks.
Comment | File | Size | Author |
---|---|---|---|
#37 | image_captcha_refresh-2608540-37.patch | 10.39 KB | gg24 |
| |||
#29 | image_captcha_refresh-2608540-29.patch | 7.49 KB | sakural |
#28 | image_captcha_refresh-2608540-27.patch | 7.46 KB | bpresles |
#26 | image_captcha_refresh-2608540-26.patch | 7.61 KB | bpresles |
#14 | image_captcha_refresh.patch | 7.4 KB | RavindraSingh |
Comments
Comment #2
svipsa CreditAttribution: svipsa commentedHey, Cool idea. Let's do it!
Comment #3
afi13 CreditAttribution: afi13 commentedThis makes sense. I'd be happy to review and test any patches made for this functionality.
Comment #4
rsvelko CreditAttribution: rsvelko as a volunteer commented+1 for this feature.
The https://www.drupal.org/project/image_captcha_refresh module has already usage of 7435 and 0 open bugs. The code is small and seems easy to review and merge into captcha.
So +1 for this.
Comment #5
rsvelko CreditAttribution: rsvelko as a volunteer commented@DmitryDrozdik: when creating the new merge patch :
- maybe u will need to stop using form_alter and put the form api code into the normal captcha module's form generator function
- when its a separate module it maybe checks if captcha module is installed - now when u merge it - remove that check cause it will be the captcha module checking itself if enabled...
Comment #6
seorusus CreditAttribution: seorusus commentedI encourage it
Comment #7
alexander.ilivanov CreditAttribution: alexander.ilivanov commented+1 for that.
Comment #8
anpolimus+1
Comment #9
ddrozdik CreditAttribution: ddrozdik commented#2501699: Fix Image CAPTCHA settings form is blocker for now.
Comment #10
iVanilla CreditAttribution: iVanilla commentedHi.
Could you develop a version of Drupal 8?
Thanks.
Comment #11
AswathyAjish CreditAttribution: AswathyAjish commentedPlease develop a D8 version of this.
Comment #12
ddrozdik CreditAttribution: ddrozdik as a volunteer commentedok. I am working on this.
Comment #13
RavindraSingh CreditAttribution: RavindraSingh commentedHave you developed some dev version of this module in D8? If yes, I can contribute in that with you.
Comment #14
RavindraSingh CreditAttribution: RavindraSingh commentedI had ported this module in Drupal 8. but as i had a discussion with @ddrozdik, He suggested to add the feature to captcha module. So here is the first working image refresh patch with Captcha 8.x-1.x branch.
This works good.
I am waiting for the captcha module maintainer if they approve this feature should be a CAPTCHA, after that I am happy to improve the below mentioned tasks -
Comment #15
RavindraSingh CreditAttribution: RavindraSingh commentedComment #16
RavindraSingh CreditAttribution: RavindraSingh commentedFor #5, We are not using form alter in new patch. I am trying to fix this from image_captcha module only.
Comment #18
naveenvalechaThat's the nice feature. +1 to be included into captcha.
Here are some more nits other than mentioned in #14
This library is using the jquery so make it dependent on the core/jquery
Add new line at EOF
Move this use statement at top ofthe file.
Remove the deprecated function.
Extra spacing.
Add new line at EOF
Add new line at EOF
We need a security token here to prevent the CSRF
Remove extra lines
Make the comment more explanatory.
Inject the database connection into controller.
use the Url component class instead.
Comment #19
RavindraSingh CreditAttribution: RavindraSingh as a volunteer and at Srijan | A Material+ Company commentedThank you @naveenvalecha, As mentioned in my last comment I will improve these issue after only if CAPTCHA module maintainer agrees on adding the feature into Drupal 8.
Comment #20
RavindraSingh CreditAttribution: RavindraSingh as a volunteer and at Srijan | A Material+ Company commentedWill pass the baseURL from Drupal setting.
Comment #21
naveenvalechaAs a co-maintainer of the module. +1 from my end. pinged to wundo & elachlan about the same. Let's improve it and get this dang in.
Comment #22
wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commentedI don't have time to work on this right now, but I'd love to have this committed to both D7 and D8 branches.
Assuming we have a good test coverage for this feature, +1.
Also, I'd make this part of the API itself, not only Image Captcha. I know some challenges implement their on "refresh" (e.g. Recaptcha), but it would be great to have this feature as challenge agnostic as possible (and allow individual challenges to suppress the standard behaviour)
Comment #23
wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commentedComment #24
ddrozdik CreditAttribution: ddrozdik as a volunteer commentedI agree that make sense to do this as part of API. I will try to find some time to do this.
Regarding D7 branch, my module is used on many sites and migration this functionality into Captcha module will make lot's of regressions.
Comment #25
elachlan CreditAttribution: elachlan commentedI like the idea of it. I think instead of a button we should use some sort of an icon. It avoids need for translation.
Comment #26
bpresles CreditAttribution: bpresles commentedFind attached an updated version of the patch
Comment #28
bpresles CreditAttribution: bpresles commentedI didn't manage to run the unit test on my dev environment (for an unknown reason, there is no "captcha" group listed by phpunit (while all my other contrib modules with tests are listed). So I try posting a possible fix and we'll see if the test pass.
Comment #29
sakural CreditAttribution: sakural as a volunteer commentedI find these patch i can't use,
it return error that i can't apply normally.
so i create one, matbe it can help someoneelse.
thanks.
Comment #30
gg24 CreditAttribution: gg24 as a volunteer and at QED42 commentedHi,
I have re-rolled the patch for 8.x-1.x and I have resolved the syntax issues as well. Please review the patch.
Thanks!
Comment #32
gg24 CreditAttribution: gg24 as a volunteer and at QED42 commentedComment #33
navneet0693 CreditAttribution: navneet0693 as a volunteer and at QED42 commentedNew lines :-)
Little of more adjustments will be required in image_captcha.libraries.yml for tests to pass. 'all' category doesn't exists
to
Comment #34
navneet0693 CreditAttribution: navneet0693 as a volunteer and at QED42 commentedComment #35
gg24 CreditAttribution: gg24 as a volunteer and at QED42 commentedMade changes as per suggestion above. Please review the patch.
Thanks!
Comment #36
navneet0693 CreditAttribution: navneet0693 as a volunteer and at QED42 commentedFinding it little bit irrelevant to context of class
Exception class not declared above. or you can use
\Exception
Using StringTranslationTait, $this->t()
++ to all who worked upon this.
Comment #37
gg24 CreditAttribution: gg24 as a volunteer and at QED42 commentedHi @navneet0693,
I have made the suggested changes. Please review the patch attached.
Thanks!
Comment #38
navneet0693 CreditAttribution: navneet0693 as a volunteer and at QED42 commentedThis should be all, good to go!
Comment #40
wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commentedComment #41
Ice-D CreditAttribution: Ice-D commentedUpdated the module via composer, now I'm getting
There indeed is no Controller of that name. But it's mentioned in image_captcha.settings.yml. What happened?
Comment #42
GreenSkunkThe patch does contain the controller BUT I can not get the patch to cleanly apply.
I've added the patch via composer and directly and both fail against the current dev.
The patch does work to add the CaptchaImageRefresh controller
Is anyone else having this problem?
Comment #43
Ice-D CreditAttribution: Ice-D commentedYes, I couldn't apply the patch either. Looking at the commit in #39, the CaptchaImageRefresh controller and a bunch of other related files seem to be missing. It would be great if one of the maintainers could take a quick look.
Comment #44
elachlan CreditAttribution: elachlan commentedThis broke the tests.
Comment #46
elachlan CreditAttribution: elachlan commentedTests are now passing.
Comment #48
Abhinaw CreditAttribution: Abhinaw as a volunteer and commentedHi All, hope doing good. DO we have image_captcha Refresh modules ?
Comment #49
Abhinaw CreditAttribution: Abhinaw as a volunteer and commentedComment #50
DAMIANC _ CreditAttribution: DAMIANC _ commented