Problem/Motivation

While editiing a text format that uses the limit allowed tags filter, if you add some tags to the allowed html tags then drag a plugin to the toolbar before having saved, you lose your changes.

Steps to reproduce:

  1. install Drupal standard
  2. edit basic HTML format (admin/config/content/formats/manage/basic_html)
  3. add <i> to the allowed html tags field (for example)
  4. add title to the <a> allowed attributes
  5. drag any button to the toolbar

Expected result: the <i> and the <a title> stays allowed
Current result: the <i> and the <a title> are removed from the allowed tags

Proposed resolution

In core/modules/filter/filter.filter_html.admin.js fix Drupal.behaviors.filterFilterHtmlUpdating._updateAllowedTags so it takes the values from the allowed HTML tags field.

Remaining tasks

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Create a patch Instructions
Update the issue summary noting if allowed during the rc Template
Add steps to reproduce the issue Novice Instructions Done

User interface changes

Fixes the bug.

API changes

None.

Data model changes

None.

Comments

DuaelFr created an issue. See original summary.

Wim Leers’s picture

Component: ckeditor.module » filter.module

This most definitely used to work; it's a regression :(

Wim Leers’s picture

Issue tags: +Needs manual testing

If we had JS testbots, this would never have happened. Gah.

Which also means this will need manual testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.