Missing @return tag in getActiveHelp(), denormalize(), createBookNode()

Thanks... I am not sure this is quite right though:

1. +++ b/core/modules/hal/src/Normalizer/ContentEntityNormalizer.php
   @@ -124,6 +124,9 @@ public function normalize($entity, $format = NULL, array $context = array()) {
   +   * @return object
   +   *   An object of the class specified with $class variable.
   +   *
       * @throws \Symfony\Component\Serializer\Exception\UnexpectedValueException
       */
      public function denormalize($data, $class, $format = NULL, array $context = array()) {
   

   That doesn't seem right to me, since the $class param documentation is:

     * @param string $class
      *   Unused, entity_create() is used to instantiate entity objects.
    

2. +++ b/core/modules/help/src/Plugin/Block/HelpBlock.php
   @@ -89,6 +89,10 @@ public static function create(ContainerInterface $container, array $configuratio
   +   *   An array containing the help texts of the active menu item as HTML
   

   texts -> text strings

   Text is not a countable noun, at least in this context, so it should not be pluralized.

Hi @jhodgdon,
Can y0u please elaborate what to write in 3.1.
Done with 3.2

Attching patch and interdiff.

@snehi,

Please try to work on the unassigned issue. There are lots of un assigned issues are available in the queue. It is assigned to some one , that means he is working on it, Please understand. You are doing this for many times. I found out in couple of issues.

Disadvantage: Somebody is assigned , they will be really following up that issues. Time is precious, should not end in wasting time of any contributors. Please do understand.

+++ b/core/modules/hal/src/Normalizer/ContentEntityNormalizer.php
@@ -124,6 +124,9 @@ public function normalize($entity, $format = NULL, array $context = array()) {
+   * @return object
+   *   A denormalized entity object from serialized entity $data variable.

Can we typehint EntityInterface if we know it will be an entity?

Thanks for the patch! Sorry for delay in review -- I've been on vacation.

I think this needs some additional work, and I don't really understand why this issue was filed about 3 random missing @return tags in 3 completely different areas of the code... but anyway:

1. +++ b/core/modules/hal/src/Normalizer/ContentEntityNormalizer.php
   @@ -124,6 +124,9 @@ public function normalize($entity, $format = NULL, array $context = array()) {
   +   *   A denormalized entity object from serialized entity $data variable.
   

   What is a "denormalized entity object"? I honestly have no idea.

2. +++ b/core/modules/help/src/Plugin/Block/HelpBlock.php
   @@ -89,6 +89,9 @@ public static function create(ContainerInterface $container, array $configuratio
   +   * @return array
   +   *   An array containing the help text strings of the active menu item as HTML.
   

   This isn't accurate. Take a look at the code -- it always returns a string.

Due to no activity for a longer time, I am assigning this issue to myself.

@ashhishhh: Normally, just after someone assigns an issue to themselves, you shouldn't jump in and make a patch. The more polite thing to do is to wait a few days, and if there is still no activity, post a comment asking if they are planning to make a patch. Only then, if there is no response, then you could assign the issue to yourself and make a patch. So going forward, if an issue is assigned to someone else, please follow that procedure. Thanks!

In any case, I reviewed the interdiff in #14... Still can be improved:

1. +++ b/core/modules/hal/src/Normalizer/ContentEntityNormalizer.php
   @@ -125,7 +125,7 @@
   +   *   An unserialize entity object from serialize entity $data variable.
   

   OK, I at least know what this means now; no idea if it is accurate. But the grammar needs a cleanup:

   unserialize => unserialized
   serialize => serialized

   And... So entity object implies it is not serialized. And presumably $data in the param docs (I hope?) says it is serialized data. So... Probably this whole thing needs rewording, to something like:

   An entity object containing the data in $data.

2. +++ b/core/modules/help/src/Plugin/Block/HelpBlock.php
   @@ -90,8 +90,8 @@
   +   *   Help text of the active menu item as HTML.
   

   This is better! But really in D8 we don't have "active menu items" any more. As you can see from the parameter, it's for the current request.

Thanks @jhodgdon.
Patch applied, kindly review it.

Thanks for the new patch! I reviewed the whole patch this time, not the interdiff...

+++ b/core/modules/hal/src/Normalizer/ContentEntityNormalizer.php
@@ -124,6 +124,9 @@ public function normalize($entity, $format = NULL, array $context = array()) {
+   *   An unserialized entity object from serialized entity $data variable.

Hmmm... See comment #16, item 1. I suggested different wording, because entity objects are by definition unserialized.

The rest looks good!

Thanks jhodgdon
Patched, please review.

+++ b/core/modules/hal/src/Normalizer/ContentEntityNormalizer.php
@@ -124,6 +124,9 @@ public function normalize($entity, $format = NULL, array $context = array()) {
+   *  An entity object containing the data in $data ¶

Blank space, Please configure your IDE for not doing this.

Patch updated, please review.

you can add description for @throws.

+   *
    * @throws \Symfony\Component\Serializer\Exception\UnexpectedValueException
    */

Thanks!

Note that #24 is out of scope for this issue. You can file a new issue about this if you want to.

There is still one problem with the patch though:

+++ b/core/modules/hal/src/Normalizer/ContentEntityNormalizer.php
@@ -124,6 +124,9 @@ public function normalize($entity, $format = NULL, array $context = array()) {
+   *  An entity object containing the data in $data

This needs to end in .

corrected and updated patch.

+++ b/core/modules/hal/src/Normalizer/ContentEntityNormalizer.php
@@ -124,6 +124,9 @@ public function normalize($entity, $format = NULL, array $context = array()) {
+   *  An unserialized entity object containing the data in $data

Missing fullstop here at the end of the line.
Anyway patch is looking good now. Thanks for your contribution.
Cheers !!!

Patch attached, please review.

OK, good! Thanks! Committed to both 8.x branches (with a small fix to indentation in EntityNormalizer).