Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
in the file: core/lib/Drupal/Core/TypedData/ListDataDefinition.php, Wrong @param documented.
Here is the changes.
@@ -103,7 +103,7 @@ public function getItemDefinition() {
/**
* Sets the item definition.
*
- * @param \Drupal\Core\TypedData\DataDefinition $definition
+ * @param \Drupal\Core\TypedData\DataDefinitionInterface $definition
* A list item's data definition.
Comment | File | Size | Author |
---|---|---|---|
wrong-param-doc-1.patch | 576 bytes | rakesh.gectcr | |
Comments
Comment #2
jhodgdonLooks fine to me.
By the way, you do not need to both (a) make a patch and (b) paste the changes into the issue summary. The patch is enough. Thanks!
Also please try to make issues with several of these small fixes together. Reviewing lots of small patches and committing them takes a lot of time.
Comment #3
catchThanks for the patch. In order clean up these sorts of coding standards fairly and efficiently, many instances of identical fixes that can be reviewed with
git diff --color-words
should be combined into a single patch, ideally one that fixes all instances in core in preparation for enabling automated coding standards checking for them. This issue is postponed for now on #2571965: [meta] Fix PHP coding standards in core.If the standard being fixed already has a coder rule, this issue should me marked as a duplicate of the issue that begins to fix that rule. If there is not yet a coder rule, we should add one. See for example #2606860: Docblock sections out of order in core/lib/Drupal.
Thanks for your ongoing efforts to clean up the codebase and fix these bugs!
Comment #4
jhodgdonComment #13
longwaveCorrect scope for this is #2723621: Fix Drupal.Commenting.FunctionComment.IncorrectTypeHint and Drupal.Commenting.FunctionComment.InvalidTypeHint