Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
In the file : core/lib/Drupal/Core/Utility/ThemeRegistry.php, Comment block @return type is missing for the function initializeRegistry()
Here is the changes,
@@ -82,7 +82,7 @@ function __construct($cid, CacheBackendInterface $cache, LockBackendInterface $l
/**
* Initializes the full theme registry.
*
- * @return
+ * @return array
* An array with the keys of the full theme registry, but the values
* initialized to NULL.
In the file : /core/lib/Drupal/Core/Utility/token.api.php
@@ -185,7 +185,7 @@ function hook_tokens_alter(array &$replacements, array $context, \Drupal\Core\Re
* module will need to implement that hook in order to generate token
* replacements from the tokens defined here.
*
- * @return
+ * @return array
* An associative array of available tokens and token types. The outer array
* has two components:
Comment | File | Size | Author |
---|---|---|---|
#3 | interdiff-2607110-1-2.txt | 564 bytes | rakesh.gectcr |
#3 | 2607110-2.patch | 1.18 KB | rakesh.gectcr |
return-type-missing-themeregistry-1.patch | 544 bytes | rakesh.gectcr | |
Comments
Comment #3
rakesh.gectcrComment #4
jhodgdonOK, thanks!
Comment #5
catchComment #6
rakesh.gectcrComment #7
xjmThanks for the patch. In order clean up these sorts of coding standards fairly and efficiently, many instances of identical fixes that can be reviewed with
git diff --color-words
should be combined into a single patch, ideally one that fixes all instances in core in preparation for enabling automated coding standards checking for them. This issue is postponed for now on #2571965: [meta] Fix PHP coding standards in core.If the standard being fixed already has a coder rule, this issue should me marked as a duplicate of the issue that begins to fix that rule. If there is not yet a coder rule, we should add one. See for example #2606860: Docblock sections out of order in core/lib/Drupal.
Thanks for your ongoing efforts to clean up the codebase and fix these bugs!
Comment #8
jhodgdonComment #17
quietone CreditAttribution: quietone as a volunteer commented@rakesh.gectcr, thanks for the patch. Closing this as a duplicate and merged the changes into #3207949: Fix Drupal.Commenting.FunctionComment.MissingParamType.
Comment #18
quietone CreditAttribution: quietone as a volunteer commentedForgot to add tag. Coding standard fixes are usually tasks, changing category.