Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
ProjectInfo::filterProjectInfo
, add @return
values and @param
modification in the comment docblocks.
Comment | File | Size | Author |
---|---|---|---|
#4 | 2606242-4.patch | 596 bytes | heykarthikwithu |
#2 | 2606242.patch | 794 bytes | heykarthikwithu |
Comments
Comment #2
heykarthikwithuAdded a patch for this.
Comment #4
heykarthikwithuComment #5
jhodgdonThanks, looks fine.
But in general, rather than filing dozens of issues, please try to combine fixes into larger patches.
Comment #6
catchThanks for the patch. In order clean up these sorts of coding standards fairly and efficiently, many instances of identical fixes that can be reviewed with
git diff --color-words
should be combined into a single patch, ideally one that fixes all instances in core in preparation for enabling automated coding standards checking for them. This issue is postponed for now on #2571965: [meta] Fix PHP coding standards in core.If the standard being fixed already has a coder rule, this issue should me marked as a duplicate of the issue that begins to fix that rule. If there is not yet a coder rule, we should add one. See for example #2606860: Docblock sections out of order in core/lib/Drupal.
Thanks for your ongoing efforts to clean up the codebase and fix these bugs!
Comment #7
jhodgdonComment #16
quietone CreditAttribution: quietone as a volunteer commentedThanks for the patch. However, we have a number of issues dealing with coding standards fixes and the community has decided that the best way to approach this is by fixing a rule at a time, rather than a file at a time. See #2571965: [meta] Fix PHP coding standards in core for the meta issue where this effort is being organized,
Moved the change here and credit to #2941148: Fix Drupal.Commenting.FunctionComment.MissingReturnType.
Closing as a duplicate.