The entity manager has been split into 11 different services: https://www.drupal.org/node/2549139

We'll want to replace the entity manager (injected into our forms, services) with the more appropriate replacement(s). In most cases that will be the EntityTypeManager, since we only call getStorage() on it.

Comments

bojanz created an issue. See original summary.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Issue summary: View changes
czigor’s picture

czigor CreditAttribution: czigor commented
Assigned: Unassigned » czigor
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented

Answering the IRC question: if the parent core class uses entity manager, then there's nothing we can do. This is about fixing the places where we do the injection ourselves.

czigor’s picture

czigor CreditAttribution: czigor at Liip commented
Status: Active » Needs review

https://github.com/commerceguys/commerce/pull/270

czigor’s picture

czigor CreditAttribution: czigor at Liip commented
Status: Needs review » Needs work

At the moment tests are failing but I cannot install commerce due to some profile2 issues.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented

@czigor
Use the latest profile -dev (from github.com/bojanz/profile or drupal.org/project/profile), I fixed all crashes yesterday.

czigor’s picture

czigor CreditAttribution: czigor at Liip commented
Status: Needs work » Needs review

Thanks! I was looking in https://www.drupal.org/project/profile2.

See comment in github, I don't know if I should fix the tests here.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Fixed

Merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.