Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Powered by Drupal block, when placed shows the "Powered by Drupal" Block title by default. Since the text in the block is also "Powered by Drupal" you see:
Powered by Drupal
Powered by Drupal
Which looks like an error.
Proposed resolution
Propose we set the title to hidden by default.
Remaining tasks
None.
User interface changes
'Display title' of the 'Powered by Drupal' block is no longer selected by default.
API changes
N/A.
Data model changes
N/A.
| Comment | File | Size | Author |
|---|---|---|---|
| #25 | 2604974_chrome_public_after.jpg | 4.84 KB | Edit Olah |
| #25 | 2604974_chrome_public_before.png | 2.35 KB | Edit Olah |
| #7 | 2604974-7.patch | 3.52 KB | Chi |
| #18 | drupal block.png | 83.9 KB | Ramya Balasubramanian |
| #22 | powered-by-drupal-block.png | 25.09 KB | Chi |
Comments
Comment #2
ozinHi @tkoleary,
I think it doesn't make sense to do this, because you can disable the block title with your install profile as the Standard Drupal profile does it into the configuration yaml file block.block.bartik_powered.yml. Developers can add such file to their projects and disable the block title, so we do not need to do an exception for this block in core.
What do you think about this, can we close this issue with status Works as designed?
Comment #3
tstoeckler@ozin: Yes, it's possible to disable the title explicitly if you want that via multiple means. However, I think @tkoleary means that we should disable it by default for usability reasons. We already to this for a number of blocks (Branding, Local actions, Local tasks, ...) and I think the Powered by Drupal Block is a good candidate for this as well.
I cooked up a quick patch which resembles what we do with the other block types. It's possible to write tests for this, not sure if we want to do this as this is not really logic, but I'll leave that for the committers to decide.
But @tkoleary maybe you can give this a spin to see if this is what you were after?
Comment #5
dcrocks CreditAttribution: dcrocks as a volunteer commentedNote that this only a 'Place Block' issue, and not an installation one. The simplest solution is to educate admins to uncheck the 'label display' check box in the 'Place Block' form for a new block or the block 'Configure' form for an existing block.
Comment #6
dcrocks CreditAttribution: dcrocks as a volunteer commentedThe testing system needs a block that follows system defaults and the powered_by block is the best candidate for that. And prolem is really easy to fix thru the admin UI. I would suggest this be closed as 'works as designed'
Comment #7
Chi CreditAttribution: Chi commentedSensitive defaults make sense for me as well even though it is rather minor issue. The fix is a fairly simple.
Comment #8
tstoeckler@Chi, yay, thanks! Looks great.
Comment #9
mmatsoo CreditAttribution: mmatsoo at Chromatic commentedI believe this can be closed with a status of "Closed (outdated)". I was about to test this patch, but found that the "Display title" checkbox is unchecked by default in the Powered by Drupal block. (both on the 8.1.0-dev branch and 8.0.3)
Comment #10
dcrocks CreditAttribution: dcrocks as a volunteer commentedI just did git clones of both 8.0.3 and 8.1.0 and they both had the 'display title' box checked by default. How did you build your installations?
Comment #11
priyanka.singh CreditAttribution: priyanka.singh commentedComment #12
priyanka.singh CreditAttribution: priyanka.singh commentedComment #13
priyanka.singh CreditAttribution: priyanka.singh as a volunteer commentedUsing new installation of 8.1.x-dev: Unable to reproduce this issue. The block was rendering fine.
Comment #14
priyanka.singh CreditAttribution: priyanka.singh as a volunteer commentedComment #15
Chi CreditAttribution: Chi commentedBecause the title was hidden somewhere in installation profile. The issue is about default settings. I just checked it on 8.1.x and the title is still enabled by default.
Comment #16
Ramya Balasubramanian CreditAttribution: Ramya Balasubramanian commentedHi,
I have downloaded this patch and made changes in corresponding files. This is not working for me.
Comment #18
Ramya Balasubramanian CreditAttribution: Ramya Balasubramanian commentedIn 8.1 and 8.2 dev version ,'powered by Drupal' block title is not shown by default. Without applying a patch its working.
Comment #19
emma.mariaComment #20
Chi CreditAttribution: Chi commented@Ramya Balasubramanian, don't test existing bartik_powered block, but try to place new 'Powered by Drupal' block. See note #15 for explanations.
Comment #21
emma.mariaThis needs screenshots to show on a clean install that the block title is not being printed on the front end. Then this issue will be RTBC.
Comment #22
Chi CreditAttribution: Chi commentedSimple test link (Drupal 8.2.x + patch #7):
https://m0cfp.ply.st/
Comment #23
Edit Olah CreditAttribution: Edit Olah at Code Enigma commentedThis afternoon, I am going to work on this, in the sprint at DrupalCamp London, and attach screenshots before and after applying the patch.
Comment #24
dcrocks CreditAttribution: dcrocks as a volunteer commentedBefore and after images. As you can see, the default value of the 'display title' box, when being placed, has changed from checked to un-checked, which is what this patch is about.
Comment #25
Edit Olah CreditAttribution: Edit Olah at Code Enigma commentedI have tested the patch and attached the end-user view before and after screenshots.
Before:
After:
My test makes me believe that this issue is now RTBC.
Comment #26
rachel_norfolkThanks for your very first contribution (at Drupalcamp London), Edit!
Comment #27
alexpottCommitted c157935 and pushed to 8.1.x and 8.2.x. Thanks!
If people feel strongly we could even put this in 8.0.x as this only changes new installations and new placements of the powered by block - which I feel is a good decision.