Unique field fails on multiple values of a select list field [#2604158]

I'm experiencing an error using Unique Field. I have a content type which contains a multiple value select list field where I've set it to be Unique. The module works as expected as long as you only use a single value, but the field for the content type can have multiple values.Unique Field stops checking that field and let's it through, even though it's not unique.

Comment	File	Size	Author
#3	Unique_field_fails_on_multiple_values_of_a_select_list_field_2604158-#3.patch	1.43 KB	umangamu

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

29 October 2015 at 12:17

umangamu created an issue. See original summary.

Comment #2

umangamu CreditAttribution: umangamu commented 30 October 2015 at 04:37

Issue tags:

+unique field

Comment #3

umangamu CreditAttribution: umangamu commented 17 November 2015 at 11:12

File	Size
Unique_field_fails_on_multiple_values_of_a_select_list_field_2604158-#3.patch	1.43 KB

Comment #4

umangamu CreditAttribution: umangamu commented 17 November 2015 at 11:29

Status:

Active

» Needs review

Comment #5

rakesh.gectcr

he/him

Malayalam

Manchester

CreditAttribution: rakesh.gectcr as a volunteer and at Valuebound commented 27 November 2015 at 20:47

Status:

Needs review

» Needs work

Thanks for the patch, Please add a little comment above your changes.

@@ -281,10 +281,25 @@ function unique_field_match_value($field, $values, $scope, $ntype = NULL, $nlang
         if (!strlen($val) || !is_scalar($val)) {
           continue;
         }
-        $efq->fieldCondition($field, $key, $val);
+        $field_values[] = array('key' => $key, 'val' => $val);
       }
     }
   }
+  if ($field_info->cardinality) {
+    $field_values = reset($field_values);
+    $val = $field_values['val'];
+    $key = $field_values['key'];
+    $efq->fieldCondition($field, $key, $val);
+  }
+  else {
+    $val = array();
+    $key = '';
+    foreach ($field_values as $k => $v) {
+      $val[] = $v['val'];
+      $key = $v['key'];
+    }
+    $efq->fieldCondition($field, $key, $val, 'IN');
+  }

and

foreach ($field_values as $k => $v) {

Please use little more descriptive varibales