Problem/Motivation
#2590993: Create stub entities with proper default values got an exception in d7/MigrateDblogConfigsTest, the tl;dr of which is that it exposed the fact that the dblog_row_limit variable it's supposed to be migrating is not set in the test fixture. The assertions pass (without the stub patch) because the value they're testing for, 1000, is the default value in D8. The d6 test has the same issue - the value in the fixture is 1000, so we're proving nothing by asserting the final value as 1000.
Proposed resolution
Set the dblog_row_limit variable in both the D6 and D7 test fixtures to something other than 1000, and assert that value in the tests.
Remaining tasks
Fix it
User interface changes
N/A
API changes
None
Data model changes
None
Comment | File | Size | Author |
---|---|---|---|
#7 | 2603798-7.patch | 2.92 KB | phenaproxima |
#6 | dblog_settings_tests-2603798-6.patch | 3.21 KB | neclimdul |
#4 | 2603798-4.interdiff.txt | 2.18 KB | neclimdul |
Comments
Comment #2
phenaproximaBam! Let's get this rinky-dink thing out of the way.
Comment #3
mikeryanSorry, should have pointed out that the allowed values in both D6 and D8 (didn't check D7, because duh) are 100, 1000, 10000, 100000, 1000000 - we should use one of those values.
Comment #4
neclimdulComment #5
mikeryanUmmm.... The interdiff looks good, but I think you uploaded the wrong patch...
Comment #6
neclimdulI can't even...
Comment #7
phenaproxima-- @mikeryan on IRC
Comment #8
mikeryan*That's* what I'm talking about - RTBC pending successful tests.
Comment #13
phenaproximaComment #14
webchickCommitted and pushed to 8.0.x. Thanks!