Problem/Motivation

#2590993: Create stub entities with proper default values got an exception in d7/MigrateDblogConfigsTest, the tl;dr of which is that it exposed the fact that the dblog_row_limit variable it's supposed to be migrating is not set in the test fixture. The assertions pass (without the stub patch) because the value they're testing for, 1000, is the default value in D8. The d6 test has the same issue - the value in the fixture is 1000, so we're proving nothing by asserting the final value as 1000.

Proposed resolution

Set the dblog_row_limit variable in both the D6 and D7 test fixtures to something other than 1000, and assert that value in the tests.

Remaining tasks

Fix it

User interface changes

N/A

API changes

None

Data model changes

None

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikeryan created an issue. See original summary.

phenaproxima’s picture

Bam! Let's get this rinky-dink thing out of the way.

mikeryan’s picture

Status: Needs review » Needs work

Sorry, should have pointed out that the allowed values in both D6 and D8 (didn't check D7, because duh) are 100, 1000, 10000, 100000, 1000000 - we should use one of those values.

mikeryan’s picture

Status: Needs review » Needs work

Ummm.... The interdiff looks good, but I think you uploaded the wrong patch...

neclimdul’s picture

phenaproxima’s picture

This is D8 core development - a simple test change needs three developers and six patches :P

-- @mikeryan on IRC

mikeryan’s picture

Status: Needs review » Reviewed & tested by the community

*That's* what I'm talking about - RTBC pending successful tests.

The last submitted patch, 6: dblog_settings_tests-2603798-6.patch, failed testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 7: 2603798-7.patch, failed testing.

The last submitted patch, 7: 2603798-7.patch, failed testing.

The last submitted patch, 6: dblog_settings_tests-2603798-6.patch, failed testing.

phenaproxima’s picture

Status: Needs work » Reviewed & tested by the community
webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 9f74e47 on
    Issue #2603798 by neclimdul, phenaproxima, mikeryan: dblog_settings...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.