When only stacking tables, tablesaw.stackonly.css is provided. It is much smaller than tablesaw.css and makes far fewer overrides to existing CSS. As a result, responsive_tables_filter.css would no longer be needed. This fixes the #2601436: Heading text color is changed.

CommentFileSizeAuthor
#4 responsive_tables_filter-stackonly_css-2603690-4-D7.patch8.31 KBmark_fullmer
#2 responsive_tables_filter-stackonly_css-2603690-2-D7.patch1.85 KBLiam Morland
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Liam Morland created an issue. See original summary.

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland at University of Waterloo commented
Status: Active » Needs review
FileSize
responsive_tables_filter-stackonly_css-2603690-2-D7.patch1.85 KB

This patch needs to be applied after #2603666: Combine code that adds CSS and JS.

Status: Needs review » Needs work

The last submitted patch, 2: responsive_tables_filter-stackonly_css-2603690-2-D7.patch, failed testing.

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
CreditAttribution: mark_fullmer as a volunteer commented
FileSize
responsive_tables_filter-stackonly_css-2603690-4-D7.patch8.31 KB

This patch (also committed to 7.x-1.x), addresses the following requests:

  • Allow xpath queries via drupal variable 'responsive_tables_filter_table_xpath'
  • Make CSS/JS add code DRYer with _responsive_tables_filter_add_js_css()
  • Use tablesaw.stackonly.css instead of tablesaw.css to remove module theme requirement
Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland at University of Waterloo commented
Assigned: Liam Morland » Unassigned
Status: Needs work » Fixed

Thanks very much.

It is best to have one commit for every issue instead of combining fixes for multiple issues into one commit. This makes it easier to understand what changes where made and why. It is also much easier to roll-back a change if it is later found to be undesirable.

If you follow the Drupal Git commit message convention of starting the commit message with "Issue #123:", then the issue will get an automatic comment which links to the commit.

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
CreditAttribution: mark_fullmer as a volunteer commented

Thanks for the reminder about separate commits. I'll do that in the future.

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
CreditAttribution: mark_fullmer as a volunteer commented
Status: Fixed » Closed (fixed)
Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland at University of Waterloo commented

Thanks, Mark.

When issues have "fixed" status, they will automatically change to "Closed (fixed)" after two weeks without any comments. The idea is that issues stay in the issue queue for this time to allow verification of the fix and for other people experiencing the problem to easily see that the issue has already been reported and fixed.